fix: remove redundant WaitForWorkflow in TestInputOnMount#15982
Open
Joibel wants to merge 1 commit intoargoproj:mainfrom
Open
fix: remove redundant WaitForWorkflow in TestInputOnMount#15982Joibel wants to merge 1 commit intoargoproj:mainfrom
Joibel wants to merge 1 commit intoargoproj:mainfrom
Conversation
TestInputOnMount called WaitForWorkflow() (ToBeDone) followed by WaitForWorkflow(ToBeSucceeded). The first call is redundant because ToBeSucceeded already implies the workflow reached a terminal phase, and the framework internally detects when a workflow is done but doesn't match the requested condition. The redundant call wastes a full timeout cycle (90s in CI) on slow runs. When the pod is slow to schedule — e.g. due to resource pressure from a preceding test — the first wait burns the entire timeout before the second wait even begins, doubling the time to failure and causing flakiness. Every other test in the suite (TestOutputOnMount, etc.) uses a single WaitForWorkflow call. This aligns TestInputOnMount with that pattern. Fixes flaky TestArtifactsSuite/TestInputOnMount. Signed-off-by: Alan Clucas <alan@clucas.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant
WaitForWorkflow()(ToBeDone) call beforeWaitForWorkflow(fixtures.ToBeSucceeded)inTestInputOnMountThis test is timing out regularly in CI