Skip to content

fix(server): strip baseHRef prefix from asset paths in static file server #16151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irwinrex wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

fix(server): strip baseHRef prefix from asset paths in static file server #16151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b8eba
fix(server): strip baseHRef prefix from asset paths in static file se…
irwin-rex May 28, 2026
f971830
Merge branch 'main' into main
irwinrex Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion server/static/static.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,17 @@ func (s *FilesServer) ServerFiles(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Strict-Transport-Security", "max-age=31536000")
}

if r.URL.Path == "/" || !s.uiAssetExists(r.URL.Path) {
// Strip baseHRef prefix so assets resolve correctly when behind a reverse proxy
assetPath := r.URL.Path
if s.baseHRef != "/" && s.baseHRef != "" {
basePath := "/" + strings.Trim(s.baseHRef, "/")
assetPath = strings.TrimPrefix(assetPath, basePath)
if assetPath == "" || !strings.HasPrefix(assetPath, "/") {
assetPath = "/" + assetPath
}
}

if r.URL.Path == "/" || !s.uiAssetExists(assetPath) {
data, err := s.getIndexData()
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
Expand All @@ -64,6 +74,7 @@ func (s *FilesServer) ServerFiles(w http.ResponseWriter, r *http.Request) {
http.ServeContent(w, r, "index.html", modTime, bytes.NewReader(data))
} else {
staticFS, _ := fs.Sub(s.staticAssets, ui.EMBED_PATH)
r.URL.Path = assetPath
http.FileServer(http.FS(staticFS)).ServeHTTP(w, r)
}
}
Expand Down
Loading