chore: add helm valuefiles wildcard support examples#465
chore: add helm valuefiles wildcard support examples#465nitishfy wants to merge 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
reggie-k
left a comment
reggie-k
left a comment
There was a problem hiding this comment.
Should we put it here maybe?
https://github.com/argoproj/argocd-example-apps
|
@reggie-k I didn't understand what you mean. We're putting that already in the argocd-example-apps repository. |
| valueFiles: | ||
| # no files will be matched, but since ignoreMissingValueFiles is true, it will not error out | ||
| # hence default values will be used for the helm chart | ||
| - values/no-match/staging-*.yaml |
There was a problem hiding this comment.
| - values/no-match/staging-*.yaml | |
| - values/no-match/staging-*.yaml | |
| destination: |
(The spaces number may be wrong though as suggesting from the GH UI)
Oh SORRY! Getting senile, thought it was at the main repo. Thanks! |
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
You're missing destination: in app-08.yaml
agaudreault
left a comment
agaudreault
left a comment
There was a problem hiding this comment.
Follow the pattern of existing apps.
This is to provide examples of the features supported by Argo. I don't think it is necessary to have 8 different apps for this feature. Just add one. The other features should be documented and validated as unit tests.
4 participants
Examples for argoproj/argo-cd#26768