fix: health status is set to healthy for statefulset with updateStrat… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 55.80% 55.73% -0.07%
==========================================
Files 25 25
Lines 2724 2729 +5
==========================================
+ Hits 1520 1521 +1
- Misses 1065 1070 +5
+ Partials 139 138 -1
Continue to review full report at Codecov.
|
alexmt
requested changes
Sep 1, 2020
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
glasser
reviewed
May 10, 2024
| if sts.Spec.UpdateStrategy.Type == appsv1.OnDeleteStatefulSetStrategyType { | ||
| return &HealthStatus{ | ||
| Status: HealthStatusHealthy, | ||
| Message: fmt.Sprintf("statefulset has %d ready pods", sts.Status.ReadyReplicas), |
There was a problem hiding this comment.
I understand the issue that this change was fixing and it makes sense to me that this counts as "healthy", but what do folks think about iterating on this so that the message lets you know whether or not UpdatedReplicas matches Replicas in the OnDelete case?
glasser
added a commit
to glasser/gitops-engine
that referenced
this pull request
May 10, 2024
…ealth message Since argoproj#136 we've had the policy that an OnDelete statefulset is healthy as long as the statefulset spec is updated and the right number of pods are running, even if some of the pods are old and haven't been deleted yet. That's reasonable, but it still can be helpful to be able to see directly in the health message (and eg, in the ArgoCD UI) how many replicas have been updated. This adds that to the message.
glasser
added a commit
to glasser/gitops-engine
that referenced
this pull request
May 10, 2024
…ealth message Since argoproj#136 we've had the policy that an OnDelete statefulset is healthy as long as the statefulset spec is updated and the right number of pods are running, even if some of the pods are old and haven't been deleted yet. That's reasonable, but it still can be helpful to be able to see directly in the health message (and eg, in the ArgoCD UI) how many replicas have been updated. This adds that to the message. Signed-off-by: David Glasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes argoproj/argo-cd#1881