-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry with client side dry run if server one was failed #548
feat: retry with client side dry run if server one was failed #548
Conversation
Signed-off-by: pashakostohrys <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 54.70% 54.65% -0.05%
==========================================
Files 41 41
Lines 4645 4647 +2
==========================================
- Hits 2541 2540 -1
- Misses 1908 1910 +2
- Partials 196 197 +1
☔ View full report in Codecov by Sentry. |
Tested with 1.24 and 1.25 cluster |
Signed-off-by: pashakostohrys <[email protected]>
…' into feat/server-side-dry-run-fallback # Conflicts: # pkg/sync/sync_context.go
Signed-off-by: pashakostohrys <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
…argoproj#548)" This reverts commit c0c2dd1.
…argoproj#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <[email protected]>
…idation even with server side apply (#564) * Revert "feat: retry with client side dry run if server one was failed (#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <[email protected]> * Revert "fix(server): use server side dry run in case if it is server side apply (#546)" This reverts commit 4a5648e. Signed-off-by: Anand Francis Joseph <[email protected]> * Fixed the logic to disable server side apply if it is a dry run Signed-off-by: Anand Francis Joseph <[email protected]> * Added more values in the log message for better debugging Signed-off-by: Anand Francis Joseph <[email protected]> * Fixed compilation error Signed-off-by: Anand Francis Joseph <[email protected]> * Written an inline fn to get string value of dry-run strategy Signed-off-by: Anand Francis Joseph <[email protected]> * Added comment as requested with reference to the issue number Signed-off-by: Anand Francis Joseph <[email protected]> --------- Signed-off-by: Anand Francis Joseph <[email protected]> Co-authored-by: Leonardo Luz Almeida <[email protected]>
…oj#548) * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <[email protected]> * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <[email protected]> * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Obinna Odirionye <[email protected]>
Fixes for #547
Closes: argoproj/argo-cd#16177