Fix generating incorrect names for Jobs when generateName is used
#718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/sync/sync_context.go
Outdated
| @@ -754,7 +754,7 @@ func (sc *syncContext) getSyncTasks() (_ syncTasks, successful bool) { | |||
| if targetObj.GetName() == "" { | |||
| var syncRevision string | |||
| if len(sc.revision) >= 8 { | |||
| syncRevision = sc.revision[0:7] | |||
| syncRevision = strings.Trim(sc.revision[0:7], ".") | |||
There was a problem hiding this comment.
Semver also allows dashes (-) and plus (+), I would trim for that too.
There was a problem hiding this comment.
Dashes should be fine. Let's keep only letters, numbers and -.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 54.26% 53.65% -0.61%
==========================================
Files 64 64
Lines 6164 6476 +312
==========================================
+ Hits 3345 3475 +130
- Misses 2549 2725 +176
- Partials 270 276 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a case when processing of
generateNameproduces incorrect results.For example if you have revision
1.1515.1it's being cut a1.1515.and combined with suffix that starts with-character produces name that does not comply with RFC1123.