Generate kubectl autocompletions during install#38
Open
StenAL wants to merge 2 commits intoargoproj:masterfrom
Open
Generate kubectl autocompletions during install#38StenAL wants to merge 2 commits intoargoproj:masterfrom
StenAL wants to merge 2 commits intoargoproj:masterfrom
Conversation
StenAL
force-pushed
the
kubectl-completions
branch
from
b2c15a8 to
4790aff
Compare
StenAL
changed the title
This makes `kubectl argo rollouts <TAB>` completions work by default without the user needing to any manual setup. I manually added a formula revision to the existing formulae to make sure users can get this improvement via `brew upgrade` without needing to wait for a new release version. Signed-off-by: Sten Laane <21343173+StenAL@users.noreply.github.com>
These have moved to homebrew-core Signed-off-by: Sten Laane <21343173+StenAL@users.noreply.github.com>
StenAL
force-pushed
the
kubectl-completions
branch
from
4790aff to
7ee99ba
Compare
Author
|
Hey @zachaller, I see you've been active in this repository. Tagging you as a maintainer for a review please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes
kubectl argo rollouts <TAB>completions work by default without the user needing to any manual setup.I manually added a formula revision to the existing formulae to make sure users can get this improvement via
brew upgradewithout needing to wait for a new release version.I also removed support for building
argoandargocdformulae as these are no longer built from this repository.Testing
Installed locally (
brew install --build-from-source ./kubectl-argo-rollouts.rb), tab completions work when usingkubectlcommand