Skip to content

Conversation

@KyriosGN0
Copy link

@KyriosGN0 KyriosGN0 commented Jul 24, 2025

This PR adds google pubusb service, similar to AWS SQS

should close #168

@KyriosGN0
Copy link
Author

Note: i didn't test this live, as there are no docs on how to do it, if there are any, i would gladly try them out

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 46.47887% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.82%. Comparing base (da04400) to head (507fa45).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/pubsub.go 48.43% 26 Missing and 7 partials ⚠️
pkg/services/services.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   55.41%   59.82%   +4.40%     
==========================================
  Files          46       49       +3     
  Lines        4125     3771     -354     
==========================================
- Hits         2286     2256      -30     
+ Misses       1511     1153     -358     
- Partials      328      362      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pasha-codefresh
Copy link
Member

@KyriosGN0 Could you fix conflicts? Also what docs you missing in order to test things?

Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
@KyriosGN0
Copy link
Author

@pasha-codefresh my main issue is testing locally before i can merge this branch, the docs mention only after i merge this PR, but even then, i can't get argocd to run on my macos

Signed-off-by: AvivGuiser <[email protected]>
@pasha-codefresh
Copy link
Member

Okay, I see, i will help you with testing

@KyriosGN0
Copy link
Author

Okay, I see, i will help you with testing

@pasha-codefresh will you test it yourself or would you help me set up argocd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pub/Sub service

2 participants