-
Notifications
You must be signed in to change notification settings - Fork 193
Add pubsub service to notification engine #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note: i didn't test this live, as there are no docs on how to do it, if there are any, i would gladly try them out |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 55.41% 59.82% +4.40%
==========================================
Files 46 49 +3
Lines 4125 3771 -354
==========================================
- Hits 2286 2256 -30
+ Misses 1511 1153 -358
- Partials 328 362 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@KyriosGN0 Could you fix conflicts? Also what docs you missing in order to test things? |
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
|
@pasha-codefresh my main issue is testing locally before i can merge this branch, the docs mention only after i merge this PR, but even then, i can't get argocd to run on my macos |
Signed-off-by: AvivGuiser <[email protected]>
|
Okay, I see, i will help you with testing |
@pasha-codefresh will you test it yourself or would you help me set up argocd? |
This PR adds google pubusb service, similar to AWS SQS
should close #168