Skip to content

Conversation

@loganmzz
Copy link

@loganmzz loganmzz commented Dec 17, 2025

Fix #418

@loganmzz loganmzz force-pushed the 418-googlechat-loose-cardsv2-content branch 2 times, most recently from 5a365f6 to 17b67bd Compare December 18, 2025 07:56
@pasha-codefresh
Copy link
Member

I suggest you to split PR with updating golang version and actual fix. Also you commented multiple tests, they should be removed with explanation why either uncommented

@loganmzz loganmzz force-pushed the 418-googlechat-loose-cardsv2-content branch 2 times, most recently from 3369e98 to f77e902 Compare January 19, 2026 11:58
@loganmzz
Copy link
Author

loganmzz commented Jan 19, 2026

I suggest you to split PR with updating golang version and actual fix. Also you commented multiple tests, they should be removed with explanation why either uncommented

@pasha-codefresh Sorry, at first attempt I tryied to switch to newest Google libs which required a newer version of Go. I have reverted go.mod and go.sum. But they were still updated by build commands.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.98%. Comparing base (da04400) to head (f4f2e43).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   55.41%   59.98%   +4.57%     
==========================================
  Files          46       47       +1     
  Lines        4125     3619     -506     
==========================================
- Hits         2286     2171     -115     
+ Misses       1511     1102     -409     
- Partials      328      346      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loganmzz loganmzz force-pushed the 418-googlechat-loose-cardsv2-content branch 2 times, most recently from 6e9d5ca to f4f2e43 Compare January 19, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[googlechat] Loose of cards v2 content

2 participants