Add comments to gateway.yaml#55
Open
wiggitywhitney wants to merge 1 commit intoargoproj:masterfrom
Open
Conversation
Signed-off-by: Whitney Lee <wiggitywhitney@gmail.com>
wiggitywhitney
force-pushed
the
master
branch
from
3aef748 to
a8ea2b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent forever troubleshooting why Istio wouldn't work and it ended up being the
istio: ingressgatewayselector on the Gateway resource. I needed to change it toistio: ingresssince I installed Istio using Helm. I added comments to help out the next person!