Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: improve vercel preview article #128

Closed
wants to merge 1 commit into from

Conversation

jsfez
Copy link
Collaborator

@jsfez jsfez commented Feb 2, 2024

No description provided.

@jsfez jsfez requested review from a team and gregberge and removed request for a team February 2, 2024 20:31
Copy link

argos-ci bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 5 changes Feb 2, 2024, 9:09 PM

Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Texts are complicated and smell AI, it has not any writer style, makes it boring to read.
  • It's very hard to follow the subject because you setup the CI twice, it does not make sense.
  • Writing in the first person singular makes the style heavy. Also you are writing on Argos, so we show the way. It's obvious that we are not setting this up for us. It makes it weird.
  • You can refer other articles to deep dive yes, but not to avoid explaining things in this article.
  • Trademarks are very important. It really is a huge lack of seriousness to forget a capital letter.
  • The main image is very cheap and displays "localhost:3000". I thought we were running tests in Vercel Preview, I don't follow?

I think you should either rewrite it from scratch seriously or unpublish it. An article like that brings us nothing and on the contrary, serves us badly I think.


Adapt your CI workflow with this GitHub Actions configuration to enable Argos visual testing on Vercel Previews:
1. Set up a [Next.js](https://nextjs.org/) project with [Playwright](https://playwright.dev).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dedicated link for that on Next.js doc.

@jsfez
Copy link
Collaborator Author

jsfez commented Feb 25, 2024

I should have stick to the first version and ship it. Now the momentum is lost. I suggest to delete this PR

@gregberge gregberge closed this Apr 1, 2024
@gregberge gregberge deleted the improve-vercel-preview-article branch April 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants