blog: improve vercel preview article #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsfez
requested review from
a team and
gregberge
and removed request for
a team
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
jsfez
force-pushed
the
improve-vercel-preview-article
branch
from
77d74a9 to
7606a7a
Compare
jsfez
force-pushed
the
improve-vercel-preview-article
branch
from
7606a7a to
b182e48
Compare
jsfez
force-pushed
the
improve-vercel-preview-article
branch
from
b182e48 to
aea345f
Compare
gregberge
requested changes
Feb 2, 2024
There was a problem hiding this comment.
- Texts are complicated and smell AI, it has not any writer style, makes it boring to read.
- It's very hard to follow the subject because you setup the CI twice, it does not make sense.
- Writing in the first person singular makes the style heavy. Also you are writing on Argos, so we show the way. It's obvious that we are not setting this up for us. It makes it weird.
- You can refer other articles to deep dive yes, but not to avoid explaining things in this article.
- Trademarks are very important. It really is a huge lack of seriousness to forget a capital letter.
- The main image is very cheap and displays "localhost:3000". I thought we were running tests in Vercel Preview, I don't follow?
I think you should either rewrite it from scratch seriously or unpublish it. An article like that brings us nothing and on the contrary, serves us badly I think.
|
|
||
| Adapt your CI workflow with this GitHub Actions configuration to enable Argos visual testing on Vercel Previews: | ||
| 1. Set up a [Next.js](https://nextjs.org/) project with [Playwright](https://playwright.dev). |
There was a problem hiding this comment.
There is a dedicated link for that on Next.js doc.
|
I should have stick to the first version and ship it. Now the momentum is lost. I suggest to delete this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.