Skip to content

chore: fix Dependabot alerts and update examples to latest - #420

Merged
gregberge merged 2 commits into
mainfrom
claude/argos-js-vulnerabilities-5411f2
Nov 16, 2026
Merged

gregberge merged 2 commits into
mainfrom
claude/argos-js-vulnerabilities-5411f2

Conversation

@gregberge

Copy link
Copy Markdown
Member

Description

Fixes the open Dependabot alerts and brings every example up to date.

Workspace dependencies

  • Updated every workspace dependency within its current major and refreshed pnpm-lock.yaml. No major bumps.
  • Raised the override floors for vite (^7.3.7), undici (^8.12.2) and follow-redirects (^1.16.1), and added source-map-js (^1.2.2): these were held on vulnerable versions.
  • Checked the new lockfile against the vulnerable range of each of the 57 alerts on pnpm-lock.yaml: 56 no longer match. The remaining one is deepmerge, which has no patched release and only comes in through jest.
  • lerna 10.1.1 moves to sigstore 5, so the provenance patch moves to sigstore@5.0.1. Recover Rekor duplicate-entry conflicts by default sigstore/sigstore-js#1708 made fetchOnConflict: true the default in @sigstore/sign, but sigstore 5.0.1 still passes false explicitly, so the patch is still needed.

Examples

The 14 open example alerts were dismissed as "Vulnerable code is not actually used". To stop new ones, every example dependency is now "latest": no example manifest using "latest" has ever raised an alert, while ranges and pins kept raising them (34 on examples/nextjs alone). Two exceptions can still alert:

  • storybook-legacy stays on Storybook ^8.6.19 and vite ^6.4.6, because storycap supports nothing newer than Storybook 8.
  • remix stays on React ^18, because Remix v2 caps it.

Each example was migrated to the current majors (Next 16, Tailwind 4, React Router 8, Storybook 10, WebdriverIO 10). It was then installed fresh outside the repo and run end to end, and it wrote Argos screenshots. Nothing was uploaded. Along the way:

  • Removed ESLint and template leftovers unrelated to Argos (React Router Dockerfiles, Storybook onboarding addons…).
  • WebdriverIO now uses @argos-ci/webdriverio instead of plain saveScreenshot; its config went from 289 lines to 27.
  • Puppeteer runs headless instead of opening a window.
  • Fixed Remix's start script (it crashed) and loaded its stylesheet, which was never linked.
  • Fixed React Router's Playwright webServer: it started the dev server on 5173 but waited for port 3000.
  • Example workflows now use npm install, since there's no lockfile, and actions v7. upload-artifact@v3 no longer works.
  • Fixed README links that pointed to argos-ci/argos/tree/main/examples.

Type of changes

Maintenance: dependencies and examples.

Checklist

  • The commits message follows the Conventional Commits' policy
  • Lint and unit tests pass locally: build, check-types, lint, check-format and test, plus the Playwright, Vitest, Storybook (Vitest and test-runner), Cypress, Puppeteer and WebdriverIO e2e suites with upload off.
  • I have added tests if needed: not needed.

Further comments

  • The example CI pipelines (GitHub Actions, CircleCI, Travis) were checked by linting and by reading the orb source, not by running them.
  • Remix 2.17.5 is the last v2 release and still depends on vulnerable versions of React Router 6 and turbo-stream. examples/react-router covers the same setup, so the Remix example could be retired.
  • Docs: the Playwright quickstart says screenshots go to ./screenshots. With the Argos reporter set up, they're written under test-results/.

🤖 Generated with Claude Code

gregberge and others added 2 commits November 16, 2026 13:19
Update every workspace dependency within its current major and refresh
the lockfile. Raise the override floors for vite, undici and
follow-redirects and add one for source-map-js, so the lockfile no
longer resolves any version Dependabot flags. deepmerge has no patched
release and only comes in through jest.

lerna 10.1.1 moves to sigstore 5, so the provenance patch moves to
sigstore@5.0.1: @sigstore/sign now defaults fetchOnConflict to true,
but sigstore still passes false explicitly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Declare every example dependency as "latest": Dependabot never raised an
alert on those manifests, while ranges kept raising alerts on code that
never runs. storybook-legacy stays on Storybook 8 (storycap supports
nothing newer) and remix on React 18 (Remix v2 caps it).

Migrate the examples to the current majors (Next 16, Tailwind 4, React
Router 8, Storybook 10, WebdriverIO 10) and check that each one installs
and captures Argos screenshots. Along the way:

- drop ESLint and template leftovers unrelated to Argos
- use @argos-ci/webdriverio in the WebdriverIO example
- run Puppeteer headless
- fix Remix's start script and load its stylesheet
- fix React Router's Playwright webServer port
- use npm install and actions v7 in example workflows
- point README links to argos-javascript examples

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gregberge
gregberge merged commit 746f421 into main Nov 16, 2026
77 checks passed
@gregberge
gregberge deleted the claude/argos-js-vulnerabilities-5411f2 branch November 16, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant