Skip to content

Fixes in equivalence checking of storage updates #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fixes in equivalence checking of storage updates #202

merged 2 commits into from
Sep 16, 2025

Conversation

@zoep
Copy link
Collaborator

@zoep zoep commented Sep 12, 2025 •
edited
Loading

This PR fixed the way Act updates are evaluated during equivalence checking:

  1. The LHS reference of an update is evaluated in the resulting (write) store.
  2. When creating a new contract during an update the new location is only added to the write store.
  3. A new test is added that demonstrates the semantic difference between the two approaches. The test was failing before and now it passes.

zoep added 2 commits September 12, 2025 19:41
@zoep
Few nits in udpates:
038146f 
1. Update LHS is evaluated in the write store
2. When creating new contracts the address is only added to the write store
@zoep
Remove Debug.Trace
0d2e463
@zoep zoep requested a review from lefterislazar September 15, 2025 07:37
@zoep zoep merged commit 9938807 into main Sep 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lefterislazar lefterislazar lefterislazar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zoep @lefterislazar