Optimize memory representation and operations#707
Merged
Conversation
elopez
commented
Apr 15, 2025
Collaborator
|
Thanks! I am looking at it. Only changing the concrete one is definitely OK. I'm trying to see what's the deal with the Symbolic. Feels like it'd be nice to unify the two, like you did. |
Collaborator
|
OK, I had a look. Either way Will get executed. But with your system, we first execute which is basically another copyslice. So I'd rather keep the concrete and the symbolic separate. Otherwise, it looks cool! |
This might be desirable to keep Concrete turned Symbolic memories small
elopez
commented
Apr 16, 2025
msooseth
reviewed
Apr 16, 2025
Collaborator
|
Hey! If you could remove that tunable then I think we could just merge :) Would be nice! |
Collaborator
|
Thanks, this is great! Can you please add a CHANGELOG element? Then I think we can merge :) |
Collaborator
|
Thanks! I squash-merged, so it's a single commit. I hope that's OK! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An Echidna user reported continuously increasing memory while running mstore/mcopy operations. This PR attempts to resolve that by
Checklist