Replace actions from DeterminateSystems #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
force-pushed
the
ci-replace-determinate-systems
branch
5 times, most recently
from
7b8e02f to
8dd54c5
Compare
blishko
force-pushed
the
ci-replace-determinate-systems
branch
from
8dd54c5 to
3b03ab6
Compare
It is safer to build everything from scratch
blishko
force-pushed
the
ci-replace-determinate-systems
branch
from
3b03ab6 to
b181894
Compare
blishko
changed the title
Collaborator
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to replace the GitHub actions from DeterminateSystems since their Magic Nix Cache action is discontinued.
I believe we can use
cache-nix-actionwhich simply wraps thecacheGitHub action and does not store the cache anywhere outside of GitHub.The proposed action requires a bit of manual configuration but not too much.
Moreover, I believe we only need the cache for CI build (
cipackage ofhevm, ourbuild.yamlworkflow).The other workflows,
Check DependenciesandReleasedo not need to use a cache at all.Specifically, for releases, I think it is better not to use a cache and build the environment from scratch.
There is one more change prosed here: The static build for Linux takes a long time, because it is building the whole GHC from scratch. I believe we do not need to do this on CI, where we want to have relatively quick feedback.
The release workflow will still build static binary (this is the
redistributablepackage, as opposed to thecipackage inflake.nix.Checklist