Fix Windows CI build #738
Merged
Fix Windows CI build #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent MSYS2 updates broke the build again. It turns out libff was being built by referencing the MSYS2-installed headers instead of the GHC-bundled ones. This adjusts the build process to have libff built with the same headers as the rest of hevm.
blishko
reviewed
May 13, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Looks OK, but isn't there a way to use relative path instead of this absolute path D:/a/_temp/msys64/clang64/include? Can we at least extract it to a variable instead of repeating it 4 times?
Collaborator
|
Looks like extracting to a variable actually broke the build again? |
Collaborator
Author
|
yeah, I defined the variable too late in the process 😅 I went ahead and updated it to do it earlier and also reference the path from the action, hopefully it works this time 🤞 |
blishko
approved these changes
May 13, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Nice!
This is much better, no hardcoded path :)
elopez
added a commit
to crytic/echidna
that referenced
this pull request
May 20, 2025
Equivalent of argotorg/hevm#738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent MSYS2 updates broke the build again. It turns out libff was being built by referencing the MSYS2-installed headers instead of the GHC-bundled ones. This adjusts the build process to have libff built with the same headers as the rest of hevm.
Checklist