Test: Fix parsing of contracts in ethereum-tests #908
Conversation
blishko
force-pushed
the
fix-blockchain-tests
branch
2 times, most recently
from
b74b47d to
5d2b8b0
Compare
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
My only concern is the cache JSON being removed. Now we don't check the JSON cache? Maybe it'd need a separate PR? What do you think? Otherwise, this is great, thanks!
There was a problem hiding this comment.
Shouldn't there be a cache JSON so it can be loaded for the test?
There was a problem hiding this comment.
I think @msooseth is correct, this file only needs a small modification and it should work.
There was a problem hiding this comment.
The file is not being removed. Only external fields are removed.
I think GitHub's UI is giving you a false impression. |
Due to the changes in RPC cache, parsing of contracts in blockchain tests was failing. The solution here is to use a dedicated type, `RPCContract` for serializing and deserializing contracts. To fix the blockchain tests, we bring back the JSON parsing code that was used there before. As a next step, we could refactor also how contracts are handled in these tests.
blishko
force-pushed
the
fix-blockchain-tests
branch
from
5d2b8b0 to
1fa1411
Compare
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
OK, tested and it works as expected! Thanks!
Description
Due to the changes in RPC cache, parsing of contracts in blockchain
tests was failing.
The solution here is to use a dedicated type,
RPCContractforserializing and deserializing contracts.
To fix the blockchain tests, we bring back the JSON parsing code that
was used there before.
As a next step, we could refactor also how contracts are handled in
these tests.
Fixes #907.
Checklist