Unify blockchain tests code #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for parsing and preparing benchmark from ethereum tests was mostly duplicated both in blockchain tests and performance benchmarks. Here we unify this code to avoid unnecessary duplication. We also remove the message "Parsed <filepath>". This can be added back by developer if needed for debugging.
blishko
force-pushed
the
tidy-up-bctests
branch
from
47367a9 to
dc9060c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code for parsing and preparing benchmark from ethereum tests was mostly duplicated both in blockchain tests and performance benchmarks. Here we unify this code to avoid unnecessary duplication.
Checklist