Expr: Remove expensive unnecessary simplification #926
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
approved these changes
Nov 12, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Yeah, doesn't seem crucial. Would be nice to know why it was written, i.e. if there was a particular reason. I guess not. Let's remove it. We can undo the PR later if need be, but I doubt it will be needed. May be useful to add a ChangeLog item though...
This transformation is a bit expensive to check and should not be attempted repeatedly, which is what we are doing now. It might make sense to apply it once at the very end before we encode to SMT. However, the simplification system does not support that yet. For now the simplification can be removed. We could attempt to bring it back later.
blishko
force-pushed
the
simplifications-cleanup
branch
from
f7ddfee to
2faf074
Compare
Collaborator
Author
|
Changelog entry added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This transformation is a bit expensive to check and should not be attempted repeatedly, which is what we are doing now. It might make sense to apply it once at the very end before we encode to SMT.
However, the simplification system does not support that yet. For now the simplification can be removed.
We could attempt to bring it back later.
Resolves #831.
Checklist