-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Add ccache to buildpack-deps images #16384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
|
|
|
|
|
|
|
|
|
|
| --rm \ | ||
| --volume "${PWD}:/project" \ | ||
| -u "$(id -u "${USER}"):$(id -g "${USER}")" \ | ||
| -e CCACHE_DIR=/tmp/ccache \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talk with @marcocastignoli, the reason for this change is that the user mapping above (i.e. -u) runs the container as the host user, who may not exist inside the container and cannot write to the default $HOME/.ccache. Thus we redirect ccache to /tmp which is world-writable.
r0qs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm ;)
In #16356 I created both the new buildpack-deps images and I edited
.circleci/config.ymlin the same PR. This PR is needed to do the first step separately, another PR with the.circleci/config.ymlwill follow.