Fix named error parameter encoding order in IR codegen#16453
Open
nikola-matic wants to merge 1 commit intodevelopfrom
Open
Fix named error parameter encoding order in IR codegen#16453nikola-matic wants to merge 1 commit intodevelopfrom
nikola-matic wants to merge 1 commit intodevelopfrom
Conversation
cameel
reviewed
Feb 9, 2026
| auto const& errorConstructorCall = dynamic_cast<FunctionCall const&>(*arguments[1]); | ||
| appendCode() << m_utils.requireWithErrorFunction(errorConstructorCall) << "(" <<IRVariable(*arguments[0]).name(); | ||
| for (auto argument: errorConstructorCall.arguments()) | ||
| for (auto argument: errorConstructorCall.sortedArguments()) |
Collaborator
There was a problem hiding this comment.
Dealing with named arguments is actually quite error prone. This is not the first time we have a bug of this kind (#9766). While the change here may be enough for the fix, I think we should also take some steps to prevent this happening yet again (could be a separate PR on top of the fix).
We have this FuncCallArguments struct. I think we should get rid of the arguments()/sortedArguments() pair and instead always pass around arguments in this container. Then make it iterable and only in the right, sorted order. We can keep a special method for accessing them in the call order for corner cases in which you actually do want that.
cameel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16452