Fix unchecked overflow in legacy codegen array size computation#16481
Open
Fix unchecked overflow in legacy codegen array size computation#16481
Conversation
r0qs
force-pushed
the
fix-unchecked-mul-storage-array-clear
branch
2 times, most recently
from
3aefba0 to
8dabc96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an unchecked multiplication overflow in ArrayUtils::convertLengthToSize() that could cause
deleteto silently skip storage clearing whenlength * storageSizewraps modulo2^256, leaving stale data in storage.The correct behavior is to revert (as done in the IR pipeline), because clearing
2^256slots is fundamentally impossible within gas limits. Adeletethat returns success but leaves data uncleared is incorrect.Legacy evmasm codegen now uses overflowCheckedIntMulFunction, matching via-ir behavior.