Skip to content

Conversation

@chrysn
Copy link
Member

@chrysn chrysn commented Dec 5, 2025

Some usages of the generated files are not as standalone Rust files but run through include!(), and doc comments do not work there.

This is a follow-up to #57, where in a late change I generalized having the comment everywhere rather than just in a single place. As a comment-only change, I did not test that in full. (I did re-test the rustfmt aspects in #65, but not only by manually reproducing the comment's effect, not on a full Ariel build).

Some usages of the generated files are not as standalone Rust files but
run through `include!()`, and doc comments do not work there.
@chrysn
Copy link
Member Author

chrysn commented Dec 5, 2025

… and that is still not enough because in those instances, the #![ will also trip up.

@chrysn chrysn marked this pull request as draft December 5, 2025 23:37
@chrysn chrysn changed the title "generated" remark: Don't make into a doc comment Restore functionality of generated Ariel inline modules Dec 6, 2025
@chrysn chrysn marked this pull request as ready for review December 6, 2025 00:20
This reverts some of the late changes to [57] because they would not
work for inlined files.

[57]: #57 (comment)
@chrysn chrysn force-pushed the 57-for-stable-bis branch from 3b7cca8 to 1920dc4 Compare December 6, 2025 00:22
@chrysn chrysn mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants