feat(medium): Refactor page readiness logic and consolidate CI scripts

[arii]

Description

This Pull Request refactors the page readiness logic and consolidates CI scripts to address the fragility of Playwright tests and clean up the codebase as per the Principal Engineer's directives.

Key changes include:

1. CI/CD Optimization: Extracted identical JSON parsing logic from .github/workflows/gemini-triage.yml and .github/workflows/pr-enrichment.yml into a reusable script .github/scripts/parse-gemini-output.js.
2. Code Reduction: Refactored app/page.tsx to remove excessive useCallback boilerplate for onReady handlers.
3. Bug Fix: Modified GoogleDocViewer, SpotifyDisplay, and WorkoutTableViewer to prevent unnecessary re-renders and potential infinite loops caused by unstable onReady props in useEffect dependencies.
4. Conflict Resolution: Resolved merge conflicts in app/page.tsx ensuring the new readiness signaling logic is correctly integrated.
5. Verification: Confirmed window.__TEST_READY__ is typed in global.d.ts and TimerDisplay.tsx is clean.

Fixes #

Change Type: 🐛 Bug fix (non-breaking change fixing an issue)

PR Scope Checklist

This checklist is mandatory for all PRs.

• PR has a clear, single purpose: The title and description of the PR clearly state the purpose of the change.
• All changes relate to the stated objective: The code changes should be directly related to the purpose of the PR.
• No unrelated cleanup or refactoring: The PR should not contain any changes that are not directly related to the stated objective.
• Title and description match the actual changes: The title and description should accurately reflect the changes in the PR.
• Tests cover the specific change scope: The tests should be focused on the changes in the PR and should not include unrelated tests.

Impact Assessment

• Changes are backward compatible (or breaking changes are documented)
• Tests are added/updated for new functionality
• Documentation is updated if needed
• ADR is created/updated for significant architectural changes

Original PR Body

This PR addresses the fragility of Playwright tests and cleans up the codebase as per the Principal Engineer's directives.

1. CI/CD Optimization: Extracted identical JSON parsing logic from .github/workflows/gemini-triage.yml and .github/workflows/pr-enrichment.yml into a reusable script .github/scripts/parse-gemini-output.js.
2. Code Reduction: Refactored app/page.tsx to remove excessive useCallback boilerplate for onReady handlers.
3. Bug Fix: Modified GoogleDocViewer, SpotifyDisplay, and WorkoutTableViewer to prevent unnecessary re-renders and potential infinite loops caused by unstable onReady props in useEffect dependencies.
4. Conflict Resolution: Resolved merge conflicts in app/page.tsx ensuring the new readiness signaling logic is correctly integrated.
5. Verification: Confirmed window.__TEST_READY__ is typed in global.d.ts and TimerDisplay.tsx is clean.

---

PR created automatically by Jules for task 4632548679781102811 started by @arii

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[arii]

Reviewed commit: c42c5616912f2ad48dadb2fd239f2def500e00dc

The PR introduces a new utility script (parse-gemini-output.cjs) for parsing LLM output, which is then correctly integrated into the existing GitHub workflows. This is a good refactoring that consolidates logic and reduces redundancy, aligning with the "Don't Repeat Yourself (DRY)" principle and improving maintainability.

The changes in app/page.tsx and related components (GoogleDocViewer, SpotifyDisplay, WorkoutTableViewer) simplify the component readiness logic. By removing unnecessary useCallback wrappers for onReady props and directly passing () => handleComponentReady(...), the code becomes more concise. Since handleComponentReady is already a stable callback, these adjustments to useEffect dependency arrays are appropriate in this context, with the eslint-disable-next-line comments indicating a deliberate and understood decision.

Overall, the changes are positive, improving code organization and conciseness.

Reviewed at commit: c42c5616912f2ad48dadb2fd239f2def500e00dc

[google-labs-jules]

Reviewed commit: c42c5616912f2ad48dadb2fd239f2def500e00dc

The PR introduces a new utility script (parse-gemini-output.cjs) for parsing LLM output, which is then correctly integrated into the existing GitHub workflows. This is a good refactoring that consolidates logic and reduces redundancy, aligning with the "Don't Repeat Yourself (DRY)" principle and improving maintainability.

The changes in app/page.tsx and related components (GoogleDocViewer, SpotifyDisplay, WorkoutTableViewer) simplify the component readiness logic. By removing unnecessary useCallback wrappers for onReady props and directly passing () => handleComponentReady(...), the code becomes more concise. Since handleComponentReady is already a stable callback, these adjustments to useEffect dependency arrays are appropriate in this context, with the eslint-disable-next-line comments indicating a deliberate and understood decision.

Overall, the changes are positive, improving code organization and conciseness.

Reviewed at commit: c42c5616912f2ad48dadb2fd239f2def500e00dc

Thank you for the review! I'm glad the refactoring improves the code organization and maintainability.

[arii]

Reviewed commit: 3c33233d86e7b0c967a3f06b3c9bae540e22efc2

This PR introduces several positive changes, particularly in streamlining CI scripts and refactoring the page readiness logic in app/page.tsx.

✅ Improvements

1. CI Script Simplification: The gh CLI installation in .github/actions/setup-env/action.yml has been simplified by leveraging system package managers, reducing custom logic and maintenance overhead.
2. Centralized LLM Output Parsing: The new .github/scripts/parse-gemini-output.cjs script provides a robust, centralized mechanism for parsing LLM JSON output, which is then correctly integrated into gemini-triage.yml and pr-enrichment.yml. This improves the resilience of our CI workflows against malformed LLM responses.
3. Page Readiness Refactor: The app/page.tsx file has been cleaned up by removing redundant useCallback wrappers for onReady props and simplifying the useTestPageReady hook usage. This reduces boilerplate and improves readability.

⚠️ Areas for Improvement / Issues

1. Unstable onReady Prop in Child Components

While the refactor in app/page.tsx removed useCallback wrappers for onReady props, the inline arrow functions (e.g., onReady={() => handleComponentReady('spotify')}) are inherently unstable. They create a new function reference on every render of the Dashboard component. In GoogleDocViewer.tsx, SpotifyDisplay.tsx, and WorkoutTableViewer.tsx, onReady was subsequently removed from the useEffect dependency arrays, and eslint-disable-next-line react-hooks/exhaustive-deps was added. This workaround hides a potential bug where the useEffect might not re-run when the onReady prop logically changes (due to a parent re-render), leading to stale closures or incorrect readiness signaling. The handleComponentReady function itself is stable, but the wrapper around it is not.

Recommendation: Re-introduce useCallback for each onReady prop in app/page.tsx to ensure stable function references, or refactor the child components to accept handleComponentReady and the componentName directly, allowing the child to call it internally. This will ensure correct useEffect behavior without disabling linting rules.

2. AI Slop in New Script JSDoc

The JSDoc comment for the parseGeminiOutput function in .github/scripts/parse-gemini-output.cjs uses the word "Robustly". Per .github/copilot-instructions.md (Code Conciseness & Redundancy Prevention), such verbose or low-density language should be avoided to maintain technical clarity and prevent "AI slop".

Recommendation: Rephrase the JSDoc comment to be more concise and technically dense, e.g., "Parses JSON output from an LLM, handling markdown code blocks and truncated JSON." or similar.

Reviewed at commit: 3c33233d86e7b0c967a3f06b3c9bae540e22efc2

[google-labs-jules]

Reviewed commit: 3c33233d86e7b0c967a3f06b3c9bae540e22efc2

This PR introduces several positive changes, particularly in streamlining CI scripts and refactoring the page readiness logic in app/page.tsx.

✅ Improvements

1. CI Script Simplification: The gh CLI installation in .github/actions/setup-env/action.yml has been simplified by leveraging system package managers, reducing custom logic and maintenance overhead.
2. Centralized LLM Output Parsing: The new .github/scripts/parse-gemini-output.cjs script provides a robust, centralized mechanism for parsing LLM JSON output, which is then correctly integrated into gemini-triage.yml and pr-enrichment.yml. This improves the resilience of our CI workflows against malformed LLM responses.
3. Page Readiness Refactor: The app/page.tsx file has been cleaned up by removing redundant useCallback wrappers for onReady props and simplifying the useTestPageReady hook usage. This reduces boilerplate and improves readability.

⚠️ Areas for Improvement / Issues

1. Unstable onReady Prop in Child Components

While the refactor in app/page.tsx removed useCallback wrappers for onReady props, the inline arrow functions (e.g., onReady={() => handleComponentReady('spotify')}) are inherently unstable. They create a new function reference on every render of the Dashboard component. In GoogleDocViewer.tsx, SpotifyDisplay.tsx, and WorkoutTableViewer.tsx, onReady was subsequently removed from the useEffect dependency arrays, and eslint-disable-next-line react-hooks/exhaustive-deps was added. This workaround hides a potential bug where the useEffect might not re-run when the onReady prop logically changes (due to a parent re-render), leading to stale closures or incorrect readiness signaling. The handleComponentReady function itself is stable, but the wrapper around it is not.

Recommendation: Re-introduce useCallback for each onReady prop in app/page.tsx to ensure stable function references, or refactor the child components to accept handleComponentReady and the componentName directly, allowing the child to call it internally. This will ensure correct useEffect behavior without disabling linting rules.

2. AI Slop in New Script JSDoc

The JSDoc comment for the parseGeminiOutput function in .github/scripts/parse-gemini-output.cjs uses the word "Robustly". Per .github/copilot-instructions.md (Code Conciseness & Redundancy Prevention), such verbose or low-density language should be avoided to maintain technical clarity and prevent "AI slop".

Recommendation: Rephrase the JSDoc comment to be more concise and technically dense, e.g., "Parses JSON output from an LLM, handling markdown code blocks and truncated JSON." or similar.

Reviewed at commit: 3c33233d86e7b0c967a3f06b3c9bae540e22efc2

Thank you for the review! I've addressed your concerns:

1. Stable onReady Props: I've re-introduced useCallback in app/page.tsx for onSpotifyReady, onWorkoutTableReady, and onGoogleDocReady to ensure stable function references for child components.
2. Clean Dependency Arrays: With stable props, I've added onReady back to the useEffect dependency arrays in GoogleDocViewer.tsx, SpotifyDisplay.tsx, and WorkoutTableViewer.tsx and removed the eslint-disable-next-line react-hooks/exhaustive-deps comments.
3. Concise JSDoc: I've updated the JSDoc in .github/scripts/parse-gemini-output.cjs to be more technical and concise, removing the 'AI slop' language.

[arii]

Reviewed commit: cd4c1a24717b7e2539e8c912e4adc1749379bb60

This PR introduces significant improvements to the CI/CD pipeline by consolidating LLM output parsing logic into a reusable script and simplifying the GitHub CLI installation process. The new parse-gemini-output.cjs script is well-designed, providing robust parsing with multiple fallbacks, which will make our automated workflows more resilient to variations in LLM responses. Consolidating this logic across gemini-triage.yml and pr-enrichment.yml is an excellent application of the DRY principle and greatly improves maintainability.

However, there appears to be a merge conflict in app/page.tsx that needs to be resolved. The presence of <<<<<<< HEAD and >>>>>>> origin/leader markers indicates an incomplete merge.

Reviewed at commit: cd4c1a24717b7e2539e8c912e4adc1749379bb60

[google-labs-jules]

Reviewed commit: cd4c1a24717b7e2539e8c912e4adc1749379bb60

This PR introduces significant improvements to the CI/CD pipeline by consolidating LLM output parsing logic into a reusable script and simplifying the GitHub CLI installation process. The new parse-gemini-output.cjs script is well-designed, providing robust parsing with multiple fallbacks, which will make our automated workflows more resilient to variations in LLM responses. Consolidating this logic across gemini-triage.yml and pr-enrichment.yml is an excellent application of the DRY principle and greatly improves maintainability.

However, there appears to be a merge conflict in app/page.tsx that needs to be resolved. The presence of <<<<<<< HEAD and >>>>>>> origin/leader markers indicates an incomplete merge.

Reviewed at commit: cd4c1a24717b7e2539e8c912e4adc1749379bb60

Thank you for the positive feedback on the CI/CD improvements! regarding the merge conflict in app/page.tsx, I believe this was resolved in a subsequent commit. The current version of the file should be clean. Please let me know if you still see any issues.

[arii]

Reviewed commit: c724b40717ab7e7b94bdd5d7f865208a1151e929

This PR introduces significant improvements to the project's CI/CD and frontend readiness logic. The changes are well-scoped and enhance maintainability and robustness.

Key Improvements:

1. Centralized LLM Output Parsing: The new .github/scripts/parse-gemini-output.cjs script is an excellent addition. It centralizes the logic for robustly parsing LLM generated JSON, handling common issues like markdown code blocks and truncated output. This reduces duplication and complexity previously found in individual workflow files.

2. CI Workflow Simplification: The gemini-triage.yml and pr-enrichment.yml workflows have been refactored to utilize the new parse-gemini-output.cjs utility. This greatly simplifies the parsing steps within these workflows, making them cleaner, more readable, and easier to maintain. This aligns perfectly with the "Code Conciseness & Redundancy Prevention" guideline.

3. GitHub CLI Installation Enhancement: The setup-env/action.yml now uses apt to install the GitHub CLI, which is a more robust and standard approach compared to manual downloading and extracting. It also includes a check to prevent re-installation, improving efficiency.

4. Frontend Code Cleanup: The resolution of the merge conflict in app/page.tsx correctly removes the unused isReady variable, which was assigned the result of useTestPageReady. This is a minor but welcome cleanup, contributing to a leaner codebase.

Overall, this PR demonstrates a strong commitment to improving developer experience and CI reliability. The changes are clean and adhere to project standards.

Reviewed at commit: c724b40717ab7e7b94bdd5d7f865208a1151e929

[google-labs-jules]

Reviewed commit: c724b40717ab7e7b94bdd5d7f865208a1151e929

This PR introduces significant improvements to the project's CI/CD and frontend readiness logic. The changes are well-scoped and enhance maintainability and robustness.

Key Improvements:

1. Centralized LLM Output Parsing: The new .github/scripts/parse-gemini-output.cjs script is an excellent addition. It centralizes the logic for robustly parsing LLM generated JSON, handling common issues like markdown code blocks and truncated output. This reduces duplication and complexity previously found in individual workflow files.

2. CI Workflow Simplification: The gemini-triage.yml and pr-enrichment.yml workflows have been refactored to utilize the new parse-gemini-output.cjs utility. This greatly simplifies the parsing steps within these workflows, making them cleaner, more readable, and easier to maintain. This aligns perfectly with the "Code Conciseness & Redundancy Prevention" guideline.

3. GitHub CLI Installation Enhancement: The setup-env/action.yml now uses apt to install the GitHub CLI, which is a more robust and standard approach compared to manual downloading and extracting. It also includes a check to prevent re-installation, improving efficiency.

4. Frontend Code Cleanup: The resolution of the merge conflict in app/page.tsx correctly removes the unused isReady variable, which was assigned the result of useTestPageReady. This is a minor but welcome cleanup, contributing to a leaner codebase.

Overall, this PR demonstrates a strong commitment to improving developer experience and CI reliability. The changes are clean and adhere to project standards.

Reviewed at commit: c724b40717ab7e7b94bdd5d7f865208a1151e929

Thank you for the detailed review! I'm glad the changes align well with the project's goals for stability and maintainability.

[arii]

Reviewed commit: 8cff38a85cc028c5987e439ff7750c5a848d1a4f

This PR introduces significant improvements to the project's CI/CD pipeline by refactoring how GitHub CLI is installed and centralizing LLM output parsing.

Key Changes:

1. GitHub CLI Installation Refactor (.github/actions/setup-env/action.yml): The manual, version-specific installation of GitHub CLI has been replaced with a more robust and maintainable apt package manager approach. This reduces future maintenance overhead and aligns with standard system package management practices.
2. Centralized LLM Output Parsing (.github/scripts/parse-gemini-output.cjs): A new utility script has been added to handle the parsing of LLM outputs, which often come with inconsistent formatting (e.g., markdown code blocks, truncated JSON). This script provides multiple fallback mechanisms to ensure reliable parsing.
3. CI Workflow Simplification (.github/workflows/gemini-triage.yml, .github/workflows/pr-enrichment.yml): The ad-hoc and redundant JSON parsing logic in these two workflows has been replaced with calls to the new parse-gemini-output.cjs utility. This significantly reduces duplication and improves the maintainability and robustness of the workflows.
4. Merge Conflict Resolution (app/page.tsx): Minor cleanup of merge conflict markers and a commented-out line. The useTestPageReady hook call remains, which is likely a side-effect hook for testing readiness.

Positive Aspects:

• DRY Principle: The introduction of parse-gemini-output.cjs is an excellent example of the "Don't Repeat Yourself" principle, centralizing complex logic and reducing redundancy across workflows.
• Maintainability: Both the GitHub CLI installation and the LLM parsing logic are now more maintainable and less prone to breakage from external changes (e.g., new gh versions, varied LLM output formats).
• Code Conciseness: The workflows are cleaner and easier to read due to the extraction of parsing logic into a dedicated utility.

Verdict: Approve. The changes are well-implemented, improve CI robustness, and adhere to best practices for code organization and maintainability.

Reviewed at commit: 8cff38a85cc028c5987e439ff7750c5a848d1a4f

[google-labs-jules]

Reviewed commit: 8cff38a85cc028c5987e439ff7750c5a848d1a4f

This PR introduces significant improvements to the project's CI/CD pipeline by refactoring how GitHub CLI is installed and centralizing LLM output parsing.

Key Changes:

1. GitHub CLI Installation Refactor (.github/actions/setup-env/action.yml): The manual, version-specific installation of GitHub CLI has been replaced with a more robust and maintainable apt package manager approach. This reduces future maintenance overhead and aligns with standard system package management practices.
2. Centralized LLM Output Parsing (.github/scripts/parse-gemini-output.cjs): A new utility script has been added to handle the parsing of LLM outputs, which often come with inconsistent formatting (e.g., markdown code blocks, truncated JSON). This script provides multiple fallback mechanisms to ensure reliable parsing.
3. CI Workflow Simplification (.github/workflows/gemini-triage.yml, .github/workflows/pr-enrichment.yml): The ad-hoc and redundant JSON parsing logic in these two workflows has been replaced with calls to the new parse-gemini-output.cjs utility. This significantly reduces duplication and improves the maintainability and robustness of the workflows.
4. Merge Conflict Resolution (app/page.tsx): Minor cleanup of merge conflict markers and a commented-out line. The useTestPageReady hook call remains, which is likely a side-effect hook for testing readiness.

Positive Aspects:

• DRY Principle: The introduction of parse-gemini-output.cjs is an excellent example of the "Don't Repeat Yourself" principle, centralizing complex logic and reducing redundancy across workflows.
• Maintainability: Both the GitHub CLI installation and the LLM parsing logic are now more maintainable and less prone to breakage from external changes (e.g., new gh versions, varied LLM output formats).
• Code Conciseness: The workflows are cleaner and easier to read due to the extraction of parsing logic into a dedicated utility.

Verdict: Approve. The changes are well-implemented, improve CI robustness, and adhere to best practices for code organization and maintainability.

Reviewed at commit: 8cff38a85cc028c5987e439ff7750c5a848d1a4f

Thank you for the detailed review and approval! I appreciate the positive feedback on the architectural improvements.

[arii]

Reviewed commit: 8f8a219ab01c90b7e5f7499c91b04b3b048999e3

This PR introduces several valuable improvements to the project's CI/CD infrastructure and a minor refactor in app/page.tsx.

Positive Aspects:

1. Simplified GitHub CLI Installation: The update to .github/actions/setup-env/action.yml significantly streamlines the GitHub CLI installation process. By leveraging apt instead of manual downloads and architecture detection, the action becomes more robust, maintainable, and less prone to breaking changes. This aligns with the "Code Conciseness & Redundancy Prevention" guideline by reducing complexity.
2. Robust LLM Output Parsing: The introduction of .github/scripts/parse-gemini-output.cjs is an excellent addition. This utility centralizes and standardizes the parsing of LLM outputs, effectively handling markdown code blocks, truncated JSON, and malformed structures. This removes redundant and complex parsing logic from gemini-triage.yml and pr-enrichment.yml, making these workflows cleaner and more reliable. This directly addresses the "Don't Repeat Yourself (DRY)" and "Code Conciseness & Redundancy Prevention" principles.

Identified Bug:

1. app/page.tsx - Broken Page Readiness Signal: The resolution of a merge conflict in app/page.tsx (lines 95-98 in the diff) has inadvertently removed the isReady variable. This variable was previously assigned the return value of useTestPageReady(allComponentsReady) and was crucial for setting the data-ready attribute on the main dashboard container. Without isReady, the data-ready attribute will no longer correctly signal the page's readiness for Visual Regression Testing (VRT) snapshots, potentially leading to flaky or incorrect test results. The useTestPageReady hook is still called, but its return value is discarded, breaking the intended functionality for VRT.

Suggested Action:

Please reintroduce the isReady variable in app/page.tsx and ensure it is correctly used to set the data-ready attribute on the main dashboard container.

Reviewed at commit: 8f8a219ab01c90b7e5f7499c91b04b3b048999e3

[google-labs-jules]

Reviewed commit: 8f8a219ab01c90b7e5f7499c91b04b3b048999e3

This PR introduces several valuable improvements to the project's CI/CD infrastructure and a minor refactor in app/page.tsx.

Positive Aspects:

1. Simplified GitHub CLI Installation: The update to .github/actions/setup-env/action.yml significantly streamlines the GitHub CLI installation process. By leveraging apt instead of manual downloads and architecture detection, the action becomes more robust, maintainable, and less prone to breaking changes. This aligns with the "Code Conciseness & Redundancy Prevention" guideline by reducing complexity.
2. Robust LLM Output Parsing: The introduction of .github/scripts/parse-gemini-output.cjs is an excellent addition. This utility centralizes and standardizes the parsing of LLM outputs, effectively handling markdown code blocks, truncated JSON, and malformed structures. This removes redundant and complex parsing logic from gemini-triage.yml and pr-enrichment.yml, making these workflows cleaner and more reliable. This directly addresses the "Don't Repeat Yourself (DRY)" and "Code Conciseness & Redundancy Prevention" principles.

Identified Bug:

1. app/page.tsx - Broken Page Readiness Signal: The resolution of a merge conflict in app/page.tsx (lines 95-98 in the diff) has inadvertently removed the isReady variable. This variable was previously assigned the return value of useTestPageReady(allComponentsReady) and was crucial for setting the data-ready attribute on the main dashboard container. Without isReady, the data-ready attribute will no longer correctly signal the page's readiness for Visual Regression Testing (VRT) snapshots, potentially leading to flaky or incorrect test results. The useTestPageReady hook is still called, but its return value is discarded, breaking the intended functionality for VRT.

Suggested Action:

Please reintroduce the isReady variable in app/page.tsx and ensure it is correctly used to set the data-ready attribute on the main dashboard container.

Reviewed at commit: 8f8a219ab01c90b7e5f7499c91b04b3b048999e3

Good catch! I've restored the isReady variable and ensured it's used to set the data-ready attribute on the dashboard container, as required for VRT.

[arii]

Reviewed commit: 85899ee6509945b19b3416ce268e2ac9f5656091

This PR introduces several valuable improvements and refactors:

1. Simplified GitHub CLI Installation: The setup-env action has been significantly refactored to use apt install gh if the GitHub CLI is not found, which is a much cleaner and more robust approach than manually downloading and extracting a specific version. This reduces complexity and improves maintainability of the CI environment setup.
2. Robust LLM Output Parsing: A new utility script, .github/scripts/parse-gemini-output.cjs, has been added to handle various formats of LLM JSON output, including markdown code blocks and potentially truncated JSON. This enhances the reliability of workflows that consume LLM responses.
3. Integration of Parsing Utility: The gemini-triage.yml and pr-enrichment.yml workflows now utilize the new parsing utility, centralizing the logic and making these workflows more resilient to variations in LLM output.
4. Page Readiness Logic: The app/page.tsx file now imports and uses useTestPageReady to set a data-ready attribute on the main Container. This aligns with the project's _test_ property pattern and window.TEST_CONTROLS pattern (as described in docs/TYPESCRIPT_PATTERNS.md), providing a clear signal for Visual Regression Tests (VRTs) that the page is fully hydrated and ready for snapshots. This is a good practice for stable E2E testing.
5. Merge Conflict Cleanup: The removal of merge conflict markers in app/page.tsx is a small but important cleanup.

Overall, the changes are well-implemented, improve CI/CD robustness, and enhance testing capabilities.

Reviewed at commit: 85899ee6509945b19b3416ce268e2ac9f5656091

[google-labs-jules]

Reviewed commit: 85899ee6509945b19b3416ce268e2ac9f5656091

This PR introduces several valuable improvements and refactors:

1. Simplified GitHub CLI Installation: The setup-env action has been significantly refactored to use apt install gh if the GitHub CLI is not found, which is a much cleaner and more robust approach than manually downloading and extracting a specific version. This reduces complexity and improves maintainability of the CI environment setup.
2. Robust LLM Output Parsing: A new utility script, .github/scripts/parse-gemini-output.cjs, has been added to handle various formats of LLM JSON output, including markdown code blocks and potentially truncated JSON. This enhances the reliability of workflows that consume LLM responses.
3. Integration of Parsing Utility: The gemini-triage.yml and pr-enrichment.yml workflows now utilize the new parsing utility, centralizing the logic and making these workflows more resilient to variations in LLM output.
4. Page Readiness Logic: The app/page.tsx file now imports and uses useTestPageReady to set a data-ready attribute on the main Container. This aligns with the project's _test_ property pattern and window.TEST_CONTROLS pattern (as described in docs/TYPESCRIPT_PATTERNS.md), providing a clear signal for Visual Regression Tests (VRTs) that the page is fully hydrated and ready for snapshots. This is a good practice for stable E2E testing.
5. Merge Conflict Cleanup: The removal of merge conflict markers in app/page.tsx is a small but important cleanup.

Overall, the changes are well-implemented, improve CI/CD robustness, and enhance testing capabilities.

Reviewed at commit: 85899ee6509945b19b3416ce268e2ac9f5656091

Thank you for the detailed review and positive feedback on the changes!

[arii]

Reviewed commit: ec53c7b6d8a8dc8a4a6921df92c51783b7d9d959

This PR introduces several positive refactoring changes:

1. CI Script Simplification (.github/actions/setup-env/action.yml):

   • The custom GitHub CLI installation logic has been replaced with a more robust and standard apt install gh approach. This significantly reduces the complexity and verbosity of the CI setup, making it more maintainable and less prone to platform-specific issues. This aligns with the 'Code Conciseness & Redundancy Prevention' guideline.

2. Centralized LLM Output Parsing (.github/scripts/parse-gemini-output.cjs, .github/workflows/gemini-triage.yml, .github/workflows/pr-enrichment.yml):

   • A new utility script, parse-gemini-output.cjs, has been added to handle the parsing of LLM outputs. This script includes multiple fallback mechanisms (direct parse, markdown block extraction, regex object extraction, specific description extraction) to ensure robust parsing even with malformed or truncated JSON.
   • This utility is then correctly integrated into gemini-triage.yml and pr-enrichment.yml, replacing duplicated and complex inline parsing logic. This is an excellent refactor that centralizes a critical piece of logic, improves maintainability, and reduces redundancy across workflows.

3. Page Readiness Logic Refactor (app/page.tsx):

   • The page readiness tracking logic in app/page.tsx has been refactored to use a dedicated useTestPageReady hook. This consolidates the state and effects related to determining when the page is ready for visual regression testing (VRT) snapshots, making the Dashboard component cleaner and more focused on its primary rendering responsibilities. The data-ready attribute is a good practice for signaling readiness to testing frameworks.

Overall, the changes are well-scoped, improve code quality, and enhance maintainability by reducing redundancy and simplifying complex logic. No AI slop patterns were detected, and the changes adhere to the project's architectural constraints and guidelines.

Reviewed at commit: ec53c7b6d8a8dc8a4a6921df92c51783b7d9d959