Skip to content

Improve Mobile Experience for Timer Controls #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arii merged 1 commit into from
Dec 1, 2025
Merged

Improve Mobile Experience for Timer Controls #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions app/client/control/components/TimerControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,26 @@ import Stack from '@mui/material/Stack'
import TextField from '@mui/material/TextField'
import Typography from '@mui/material/Typography'
import { useCallback, useEffect, useRef, useState } from 'react'

const actionButtonSx = {
flex: 1,
fontWeight: 'bold',
py: 1.5,
minHeight: '64px',
transition: 'transform 0.1s ease-in-out',
'&:active': {
transform: 'scale(0.95)',
},
}

const stepperButtonSx = {
backgroundColor: 'grey.700',
color: 'white',
'&:hover': { backgroundColor: 'grey.600' },
width: 56,
height: 56,
}

const TimerControls = () => {
const { timerData, sendData } = useWebSocket()
// Local state is source of truth for editing
Expand Down Expand Up @@ -281,12 +301,7 @@ const TimerControls = () => {
color="primary"
onClick={() => setWorkTime((prev) => Math.max(0, prev - 5))}
aria-label="Decrease work duration"
sx={{
backgroundColor: 'grey.700',
color: 'white',
'&:hover': { backgroundColor: 'grey.600' },
p: 2,
}}
sx={stepperButtonSx}
>
<Remove fontSize="large" />
</IconButton>
Expand Down Expand Up @@ -333,12 +348,7 @@ const TimerControls = () => {
color="primary"
onClick={() => setWorkTime((prev) => prev + 5)}
aria-label="Increase work duration"
sx={{
backgroundColor: 'grey.700',
color: 'white',
'&:hover': { backgroundColor: 'grey.600' },
p: 2,
}}
sx={stepperButtonSx}
>
<Add fontSize="large" />
</IconButton>
Expand All @@ -359,12 +369,7 @@ const TimerControls = () => {
color="primary"
onClick={() => setRestTime((prev) => Math.max(0, prev - 5))}
aria-label="Decrease rest duration"
sx={{
backgroundColor: 'grey.700',
color: 'white',
'&:hover': { backgroundColor: 'grey.600' },
p: 2,
}}
sx={stepperButtonSx}
>
<Remove fontSize="large" />
</IconButton>
Expand Down Expand Up @@ -410,12 +415,7 @@ const TimerControls = () => {
color="primary"
onClick={() => setRestTime((prev) => prev + 5)}
aria-label="Increase rest duration"
sx={{
backgroundColor: 'grey.700',
color: 'white',
'&:hover': { backgroundColor: 'grey.600' },
p: 2,
}}
sx={stepperButtonSx}
>
<Add fontSize="large" />
</IconButton>
Expand All @@ -430,7 +430,7 @@ const TimerControls = () => {
variant="contained"
color="success"
onClick={() => sendTimerCommand('START')}
sx={{ flex: 1, fontWeight: 'bold', py: 1.5 }}
sx={actionButtonSx}
startIcon={<PlayArrow fontSize="large" />}
>
START
Expand All @@ -440,7 +440,7 @@ const TimerControls = () => {
variant="contained"
color="error"
onClick={() => sendTimerCommand('STOP')}
sx={{ flex: 1, fontWeight: 'bold', py: 1.5 }}
sx={actionButtonSx}
startIcon={<Stop fontSize="large" />}
>
STOP
Expand Down
Loading