Technical Debt Cleanup

.nvmrc

@@ -0,0 +1 @@
+v22.21.1

app/api/internal/clear-token/route.ts

@@ -1,3 +1,4 @@
+import { ApiError } from '@/lib/errors'
 import * as fs from 'fs'
 import { NextResponse } from 'next/server'
 import * as path from 'path'
@@ -30,6 +31,12 @@ export async function POST(_req: Request) {
       })
     }
   } catch (error) {
+    if (error instanceof ApiError) {
+      return NextResponse.json(
+        { error: error.message },
+        { status: error.statusCode }
+      )
+    }
     console.error('[API /clear-token] Error clearing token file:', error)
     return NextResponse.json(
       {

app/api/internal/token-delivery/route.ts

@@ -1,3 +1,4 @@
+import { ApiError } from '@/lib/errors'
 import fs from 'fs'
 import { NextRequest, NextResponse } from 'next/server'
 import path from 'path'
@@ -16,7 +17,7 @@ export async function POST(req: NextRequest) {
     const secretHeader = req.headers.get('x-internal-token-secret') || ''
     const expected = process.env.INTERNAL_TOKEN_DELIVERY_SECRET || ''
     if (expected && secretHeader !== expected) {
-      return NextResponse.json({ error: 'unauthorized' }, { status: 401 })
+      throw new ApiError(401, 'Unauthorized')
     }
 
     const payload = await req.json()
@@ -34,6 +35,12 @@ export async function POST(req: NextRequest) {
     console.log('Received token-delivery:', payload.sub ?? payload.provider)
     return NextResponse.json({ ok: true })
   } catch (err) {
+    if (err instanceof ApiError) {
+      return NextResponse.json(
+        { error: err.message },
+        { status: err.statusCode }
+      )
+    }
     console.error('token-delivery error:', err)
     return NextResponse.json({ error: 'server_error' }, { status: 500 })
   }

app/api/spotify/control/route.ts

@@ -7,6 +7,7 @@
 import { getServerSession } from 'next-auth/next'
 import { NextRequest, NextResponse } from 'next/server'
 import { authOptions } from '@/lib/auth'
+import { ApiError } from '@/lib/errors'
 import { withValidation } from '@/lib/middleware/validation'
 import { spotifyControlSchema } from '@/lib/validation/schemas'
 import { z } from 'zod'
@@ -18,10 +19,7 @@ const handler = async (
   const session = await getServerSession(authOptions)
 
   if (!session || !session.accessToken) {
-    return NextResponse.json(
-      { error: 'Authorization required' },
-      { status: 401 }
-    )
+    throw new ApiError(401, 'Authorization required')
   }
 
   const { command } = body
@@ -74,6 +72,12 @@ const handler = async (
       { status: response.status }
     )
   } catch (error) {
+    if (error instanceof ApiError) {
+      return NextResponse.json(
+        { error: error.message },
+        { status: error.statusCode }
+      )
+    }
     console.error('REST control failed:', error)
     return NextResponse.json(
       { error: 'Internal server error processing command.' },

app/api/spotify/devices/route.ts

@@ -1,4 +1,5 @@
 import { authOptions } from '@/lib/auth'
+import { ApiError } from '@/lib/errors'
 import { getServerSession } from 'next-auth/next'
 import { NextResponse } from 'next/server'
 
@@ -19,11 +20,7 @@ export async function GET(_req: Request) {
 
     // 2. Check if the session and token exist.
     if (!session || !session.accessToken) {
-      console.error('[API /devices] No session or access token found.')
-      return NextResponse.json(
-        { error: 'Not authenticated or token is missing.' },
-        { status: 401 }
-      )
+      throw new ApiError(401, 'Not authenticated or token is missing.')
     }
 
     // 3. Fetch devices from Spotify API.
@@ -50,6 +47,12 @@ export async function GET(_req: Request) {
     const data = await response.json()
     return NextResponse.json(data.devices || [])
   } catch (error) {
+    if (error instanceof ApiError) {
+      return NextResponse.json(
+        { error: error.message },
+        { status: error.statusCode }
+      )
+    }
     const message =
       error instanceof Error ? error.message : 'An unknown error occurred.'
     console.error(`[API /devices] Internal Server Error: ${message}`)

app/api/spotify/playlists/search/route.ts

@@ -3,6 +3,7 @@
 // This endpoint is used by the PlaylistSelector component to search for popular playlists
 
 import { authOptions } from '@/lib/auth'
+import { ApiError } from '@/lib/errors'
 import { SimplifiedPlaylist, SpotifyApi } from '@spotify/web-api-ts-sdk'
 import { getServerSession } from 'next-auth/next'
 import { NextRequest, NextResponse } from 'next/server'
@@ -23,11 +24,7 @@ export async function GET(req: NextRequest) {
 
     // 2. Check if the session and token exist.
     if (!session || !session.accessToken) {
-      console.error('[API /playlists/search] No session or access token found.')
-      return NextResponse.json(
-        { error: 'Not authenticated or token is missing.' },
-        { status: 401 }
-      )
+      throw new ApiError(401, 'Not authenticated or token is missing.')
     }
 
     // 3. Get search query from URL parameters
@@ -57,10 +54,6 @@ export async function GET(req: NextRequest) {
     )
 
     // 5. Search for playlists using the SDK
-    // The search method searches across tracks, albums, artists, and playlists
-    // Method signature: search(query: string, types: SearchType[], limit?: number, market?: string)
-    // const searchResponse = await spotify.search(query, ['playlist'], 20)
-    // Pass 'undefined' for the 3rd parameter (market) to set the 4th (limit)
     const searchResponse = await spotify.search(
       query,
       ['playlist'],
@@ -97,6 +90,12 @@ export async function GET(req: NextRequest) {
 
     return NextResponse.json({ items: searchResults })
   } catch (error) {
+    if (error instanceof ApiError) {
+      return NextResponse.json(
+        { error: error.message },
+        { status: error.statusCode }
+      )
+    }
     const message =
       error instanceof Error ? error.message : 'An unknown error occurred.'
     console.error(`[API /playlists/search] Internal Server Error: ${message}`)