Skip to content

feat(a11y): Add ARIA live regions for real-time updates #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arii merged 1 commit into from
Dec 1, 2025
Merged

feat(a11y): Add ARIA live regions for real-time updates #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions components/HrTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// File: components/HrTile.tsx
'use client'
import Box from '@mui/material/Box'
import CardContent from '@mui/material/CardContent'
import Tooltip from '@mui/material/Tooltip'
import Typography from '@mui/material/Typography'
Expand Down Expand Up @@ -34,10 +35,11 @@ const HrTile = ({ name, bpm, percentMax, background }: HrTileProps) => {
justifyContent: 'center',
}}
>
<CardContent sx={{ p: 0 }}>
{/* Giant Percentage - should dominate the tile */}
<Typography
data-testid="live-hr-percent"
<Box aria-live="polite" aria-atomic="true">
<CardContent sx={{ p: 0 }}>
{/* Giant Percentage - should dominate the tile */}
<Typography
data-testid="live-hr-percent"
sx={{
fontFamily: 'var(--font-roboto-mono), "Courier New", monospace',
fontSize: { xs: '6rem', sm: '7rem', md: '8rem' },
Expand Down Expand Up @@ -77,6 +79,7 @@ const HrTile = ({ name, bpm, percentMax, background }: HrTileProps) => {
</Typography>
)}
</CardContent>
</Box>
</StyledCard>
</Tooltip>
)
Expand Down
1 change: 1 addition & 0 deletions components/TimerDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ const TimerDisplay = ({
<Typography
data-testid="timer-phase-label"
variant="h6"
aria-live="polite"
sx={{
mb: 1,
color: phaseColor,
Expand Down
Loading