Refactor(eos_designs): Improve /metadata/cv_pathfinder.py and improve pytest coverage #5310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5310
# Activate the virtual environment
source test-avd-pr-5310/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@cv-pathfinder-coverage#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,cv-pathfinder-coverage --force
# Optional: Install AVD examples
cd test-avd-pr-5310
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
changed the title
MaheshGSLAB
commented
Apr 24, 2025
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_pathfinder.py
Show resolved
Hide resolved
MaheshGSLAB
commented
Apr 24, 2025
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_pathfinder.py
Show resolved
Hide resolved
MaheshGSLAB
commented
Apr 24, 2025
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_pathfinder.py
Show resolved
Hide resolved
MaheshGSLAB
commented
Apr 24, 2025
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_pathfinder.py
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
..._negative_unit_tests/inventory/host_vars/missing_cv_pathfinder_path_group_with_preferred.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CV_PATHFINDER_TESTS.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_pathfinder.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 15, 2025
ClausHolbechArista
added
the
one approval
Vibhu-gslab
approved these changes
May 15, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add pytest coverage for /metadata/cv_pathfinder.py
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Add pytest coverage for /metadata/cv_pathfinder.py. Coverage is 98% and the uncovered part will soon remove from schema as per comment(#5310 (comment))
How to test
Run tox
Checklist
User Checklist
Repository Checklist