-
Notifications
You must be signed in to change notification settings - Fork 268
Feat(eos_designs): Added support of Spanning Tree Port ID Allocation #5444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gmuloc
merged 7 commits into
aristanetworks:devel
from
MaheshGSLAB:issue-5257-eos-designs
Jun 3, 2025
Merged
Feat(eos_designs): Added support of Spanning Tree Port ID Allocation #5444
gmuloc
merged 7 commits into
aristanetworks:devel
from
MaheshGSLAB:issue-5257-eos-designs
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5444
# Activate the virtual environment
source test-avd-pr-5444/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-5257-eos-designs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-5257-eos-designs --force
# Optional: Install AVD examples
cd test-avd-pr-5444
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
Shivani-gslab
approved these changes
May 28, 2025
Contributor
Shivani-gslab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vibhu-gslab
approved these changes
May 28, 2025
laxmikantchintakindi
approved these changes
May 28, 2025
ClausHolbechArista
requested changes
Jun 2, 2025
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-structure.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jun 2, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Change Summary
Added support of Spanning Tree Port ID Allocation
Related Issue(s)
Fixes #5257
Component(s) name
arista.avd.eos_designsProposed changes
Added support of Spanning Tree Port ID Allocation. Earlier added the support of eos_cli_config_gen(#5286) now added support for eos_designs
How to test
Run molecule
Checklist
User Checklist
Repository Checklist