improved fix for metric updates during view change#1503
Draft
vandabbin wants to merge 1 commit intoaristocratos:mainfrom
Draft
improved fix for metric updates during view change#1503vandabbin wants to merge 1 commit intoaristocratos:mainfrom
vandabbin wants to merge 1 commit intoaristocratos:mainfrom
Conversation
d8e68f0 to
0465f1e
Compare
vandabbin
added a commit
to vandabbin/btop
that referenced
this pull request
Jan 21, 2026
vandabbin
added a commit
to vandabbin/btop
that referenced
this pull request
Jan 21, 2026
vandabbin
added a commit
to vandabbin/btop
that referenced
this pull request
Jan 21, 2026
0465f1e to
4654e9b
Compare
2585210 to
14d85bc
Compare
Contributor
Author
|
I will mark this as ready after I figure out a solution for the proc graphs and the menu Currently the proc graphs vanishing are the only problem I have to really figure out for the menu. The modifications I currently have for it work for the most part, but do this by doing collection update for any options that change the proc graphs symbols. This isn't great in my opinion so I'd really like to figure out a way to get the proc graphs symbols to change properly without a collection update like all the other graphs do. If I can't manage that I think just getting the process CPU percentages to not shift to the left when the graphs briefly vanish could be good enough. |
14d85bc to
d24c555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1498 #1500
This PR is a better version of the previous fix that had to be reverted for the fast metric updates when show/hiding box and cycling presets.
The previous fix had an issue where if the box had not been viewed since opening btop then it would not populate all the data and the box could take longer then it should to open.
This new fix prevents that by keeping track of the boxes that have been seen since btop started.
It also removes the global
Proc::resizedvariable that was used inDraw::calcSizesand replaces it with a boolean argument forDraw::calcSizesthat default totrueif it is not included. I think this is cleaner.What this fixes:
Runner::run()for each newly seen box withno_updateset to false andredrawset to falseWhat this does not fix:
Example Video (Shows fix for newly opened boxes)
Screen.Recording.2026-01-21.at.12.18.33.PM.mov