fix: mem/net proportions different after fixing min net size / mem border#1518
Merged
aristocratos merged 1 commit intoaristocratos:mainfrom Feb 7, 2026
Merged
Conversation
388e2ae to
c8f4c96
Compare
c8f4c96 to
d5acb6c
Compare
8829c6b to
7871b43
Compare
7871b43 to
dbf4d05
Compare
vandabbin
commented
Jan 29, 2026
aristocratos
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1517
I have fixed this by changing
Net::height_pfrom32to28. This compensates for the difference caused by usingfloorinstead ofceil(and not adding1in the non-gpu build) and gets the mem and net box proportions in all possible configurations and window sizes for the gpu support build as close as I can to how it was before without breaking the net box minimum size or causing the mem box bottom border to disappear. I compared this with the gpu build box size proportions from before the min net box size fix.I have fixed this by adding 1 to the height if the cpu box is shown, the net box is shown, and no gpu boxes are shown. In doing so it looks correct with no gpus shown, it looks correct with a gpu shown, it looks correct with no cpu shown and when only the mem and net boxes are shown the minimum net box size is still obeyed. The reason it checks for the net box being shown before adding 1 to the height is because if the net box is not shown then the mem bottom border will disappear like it did in the non-gpu build.Edit: It would appear that for the Non-gpu builds that while using
floorinstead ofceiland not adding+1does fix the net box minimum size and the mem bottom border when the net box is not shown, it also makes the mem box a tiny bit smaller and the net box a tiny bit bigger then it was before the change at various different window sizes for the no-gpu builds. Perhaps I should try to figure out a better fix that keeps the proportions of the boxes the exact same as they were before while still fixing the net box minimum size and mem bottom border. Thoughts? Personally I think it still looks fine even with the the net box closer in size to the mem box. When the cpu box isn't shown the mem box is still much bigger then the net box. And minimum sizes are obeyed. All the alternatives I have tried to keep the proportions the same while still fixing the issues with the mem bottom border and net box minimum size have resulted in inconsistent sizing of the net box when shrinking the height of the window past a certain size, breaking the net box minimum size again, or breaking the mem box bottom border with the net box not shown.Edit 2: I have now fixed this problem in the non-gpu-support build as well with the same change. In testing the net and mem boxes now match the original proportions from before the mem border and net min size fix in almost every single window size that I have tested. The only times that it is slightly different is when the window is very short (right around at the minimum height without proc box shown) and it is not really noticeable.
Screenshots of it fixed
GPU not shown (mem box is same size as net box and mem graphs are same size as when gpu is shown)

GPU shown

My apologies for missing this