Tweaked RX/TX collection and drawing#1521
Merged
aristocratos merged 2 commits intoaristocratos:mainfrom Jan 31, 2026
Merged
Conversation
aristocratos
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1426
This issue corrects a previous mistake I made where I forgot to update the section of
btop_draw.cppthat handles drawing the TX: and RX: labels at the bottom of the GPU box. I have also modifiedlinux/btop_collect.cppto make it so RX/TX values are collected and displayed properly for both NVML and RSMI devices (although unfortunately my Radeon 9070 XT does not support the PCIe speed function so I could not test this platform).Before:
After:
Notice how for the AMD card in "After", that the RX and TX labels are absent because no data could be collected for that card. I'm not sure if this was intended behavior, but I disabled drawing it here since it may lead the user to believe that no traffic is happening when in fact btop is just unable to read it. I can always change this back, however.