fix: Use SVG features compatible with Qt SVG Tiny 1.1#1560
Open
ratijas wants to merge 1 commit intoaristocratos:mainfrom
Open
fix: Use SVG features compatible with Qt SVG Tiny 1.1#1560ratijas wants to merge 1 commit intoaristocratos:mainfrom
ratijas wants to merge 1 commit intoaristocratos:mainfrom
Conversation
Committed on behalf of https://t.me/SergeiR Downgrades incompatible (advanced) SVG features to something supported by a default Qt SVG rendered. Besides, xlink:href is deprecated[1], and in this case introduces an unnecessary indirection. Fixes these errors causing the icon to be all black in Plasma and Qt apps: qt.svg: icon.svg:27:6: Could not resolve property: #pattern1888 qt.svg: icon.svg:27:6: Could not resolve property: #pattern1870 Interestingly enough, logo.svg doesn't need any adjustments, it's fine. [1]: https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/xlink:href
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Committed on behalf of https://t.me/SergeiR
Downgrades incompatible (advanced) SVG features to something supported by a default Qt SVG rendered. Besides, xlink:href is deprecated1, and in this case introduces an unnecessary indirection. Fixes these errors causing the icon to be all black in Plasma and Qt apps:
qt.svg: icon.svg:27:6: Could not resolve property: #pattern1888
qt.svg: icon.svg:27:6: Could not resolve property: #pattern1870
Interestingly enough, logo.svg doesn't need any adjustments, it's fine.
test.qml