feat: show/hide ip address option#1573
Open
yuheho7749 wants to merge 1 commit intoaristocratos:mainfrom
Open
Conversation
deckstose
reviewed
Apr 14, 2026
Collaborator
deckstose
left a comment
deckstose
left a comment
There was a problem hiding this comment.
We should rename this to align with the other net_ options. I also want to flip the option (since it's rather odd or special to hide the IP address). I suggest net_hide_ip or net_hide_ip_addresses and default it to false obviously.
| if (force_redraw) redraw = true; | ||
| auto net_sync = Config::getB("net_sync"); | ||
| auto net_auto = Config::getB("net_auto"); | ||
| auto show_ip = Config::getB("show_ip"); |
Author
There was a problem hiding this comment.
I was following the other Config::getB. I can change this if you want.
| {"show_ip", | ||
| "IP address visibility.", | ||
| "", | ||
| "Manually set the IP address visibility.", |
| "", | ||
| "True, False, or Auto",}, | ||
| {"show_ip", | ||
| "IP address visibility.", |
Collaborator
There was a problem hiding this comment.
This can be more direct on what happens if this is set to true. The false case is self explanatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a menu option to show or hide ip addresses. This is useful on systems with public ip addresses.
Closes #1273
Built and tested on Arch Linux 6.19.6