Skip to content

Fix: Process Tree rendering#948

Merged
deckstose merged 2 commits intoaristocratos:mainfrom
Denizantip:process_tree
Sep 10, 2025
Merged

Fix: Process Tree rendering#948
deckstose merged 2 commits intoaristocratos:mainfrom
Denizantip:process_tree

Conversation

@Denizantip
Copy link
Copy Markdown
Contributor

@Denizantip Denizantip commented Oct 5, 2024

Closes: #945
I'm not a C developer. But this is an attempt to fix process tree rendering.

@deckstose
Copy link
Copy Markdown
Collaborator

Please don't add unnecessary merge commits. I will rebase before merging anyway, or you can rebase yourself.

Also please don't beg for a review. This is a hobby project.

Comment thread src/btop_shared.cpp
Comment thread src/btop_shared.cpp
@deckstose deckstose self-requested a review July 27, 2025 22:29
Copy link
Copy Markdown
Collaborator

@deckstose deckstose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some comments again. You removed the comments on the old code blocks, but the new function is different and lacks comments.

Otherwise this looks good to me

Comment thread src/btop_shared.cpp
Comment thread src/btop_shared.hpp
Comment thread src/btop_shared.cpp Outdated
@Denizantip Denizantip force-pushed the process_tree branch 6 times, most recently from 879e510 to 25f30a5 Compare August 25, 2025 22:45
@Denizantip Denizantip requested a review from deckstose August 26, 2025 09:27
@Denizantip Denizantip changed the title Correct process tree Fix: Process Tree Aug 30, 2025
@Denizantip Denizantip changed the title Fix: Process Tree Fix: Process Tree rendering Sep 2, 2025
@deckstose deckstose merged commit e51f5c2 into aristocratos:main Sep 10, 2025
56 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Process tree rendering

2 participants