Fix ONNX optional input handling by preserving positional indices in getNodeInputs()#1
Closed
Fix ONNX optional input handling by preserving positional indices in getNodeInputs()#1
Conversation
…ndling Co-authored-by: arkq <6979798+arkq@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix input handling for Resize v11 in ONNXNodeConverterRegistry
Add ONNX Resize v10/v11 converters with correct optional input handling
Mar 6, 2026
…inputs Co-authored-by: arkq <6979798+arkq@users.noreply.github.com>
Copilot
AI
changed the title
Add ONNX Resize v10/v11 converters with correct optional input handling
Fix ONNX optional input handling by preserving positional indices in getNodeInputs()
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNodeInputs()compacted the returned vector by skipping empty input names, breaking positional indexing for any op with optional inputs. For Resize v11, this caused the ROI input (index 1, commonly empty) to shift scales and sizes to wrong indices, and incorrectly rejected valid nodes.Changes
getNodeInputs()refactor — returnsnullptrfor empty input names instead of skipping them;inputs[N]now always refers to the Nth ONNX input regardless of preceding optional inputsResize.cppconvertResizeV11— drops theonnx_node.input()workaround; usesgetNodeInputs()directly with clean positional access:inputs[0]→ X,inputs[1]→ ROI (nullptr when absent),inputs[2]→ scales,inputs[3]→ sizesConv.cpp/ConvTranspose.cpp— bias detection updated frominputs.size() > 2toinputs.size() > 2 && inputs[2] != nullptrto correctly handle a bias with an empty nameConverterContextTest/getNodeInputs_preserves_positional_indicesverifying that a node with inputs["a", "", "b"]yields[a, nullptr, b]💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.