Allow cyclic unions to discriminate on nested paths #1553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cyclic union discrimination
Fixes #1547
Problem
Discriminated unions containing circular references were completely excluded from discrimination, causing validation to check all branches and produce confusing error messages referencing irrelevant branches.
Solution
Allow cyclic unions to use property-based discrimination (e.g., a
typediscriminator field) while blocking structural discrimination that would attempt to describe the entire recursive structure.The fix filters discrimination candidates to only include those with
path.length > 0, ensuring cyclic unions discriminate on specific properties rather than overall object structure.Changes
discriminate()path.length === 0) for cyclic unionsExample