fix(type): anchor UUID #versioned regex to reject partial matches#1602
Open
WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
Open
fix(type): anchor UUID #versioned regex to reject partial matches#1602WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Clean, minimal fix. The ^/$ anchors on #versioned bring it in line with all the individual version regexes (v1–v8), and the regression test covers both leading and trailing content. No issues found.
Author
|
Why haven't you said so when string.uuid was implemented pullfron🧐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #1601
The
#versionedprivate regex in the UUIDScope.modulewas missing^and$anchors, causingtype("string.uuid")to accept strings that merely contain a UUID substring (e.g."dbb1e8e0-...1b extra stuff").All individual version regexes (
v1–v8) already used anchored patterns viaregexStringNode()— only#versionedwas missing them.^/$anchors to the#versionedregexTest plan
"rejects partial matches"test verifies both trailing and leading contentpnpm prCheckspasses (format, lint, typecheck, full test suite)