feat(type): add string.base58 built-in validator#1604
Open
WolfieLeader wants to merge 4 commits intoarktypeio:mainfrom
Open
feat(type): add string.base58 built-in validator#1604WolfieLeader wants to merge 4 commits intoarktypeio:mainfrom
WolfieLeader wants to merge 4 commits intoarktypeio:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Clean, minimal addition. Regex correctly implements the Base58 alphabet (1-9A-HJ-NP-Za-km-z), properly excluding 0/O/I/l. Tests cover all excluded characters and the empty-string edge case. Follows the existing hex pattern exactly.
Author
|
Thanks pullfrog🐸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #1520
Adds
string.base58as a built-in string validator following the existinghexpattern.Base58 alphabet (per IETF draft and Bitcoin spec):
123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyzExcludes:
0(zero),O(capital o),I(capital i),l(lowercase L)/^[1-9A-HJ-NP-Za-km-z]+$/(uses+likehex, rejects empty strings)regexStringNode(), added toScope.moduleand namespace$type0,O,I,l)Test plan
pnpm prCheckspasses (format, lint, typecheck, full test suite)