Optimize SparseTerm comparisons and constant checks#1063
Open
ANtutov wants to merge 1 commit intoarkworks-rs:masterfrom
Open
Optimize SparseTerm comparisons and constant checks#1063ANtutov wants to merge 1 commit intoarkworks-rs:masterfrom
ANtutov wants to merge 1 commit intoarkworks-rs:masterfrom
Conversation
ANtutov
requested review from
Pratyush,
mmagician and
z-tech
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces redundant work in SparseTerm hot paths without altering semantics. In partial_cmp, computing degree() for both sides once and reusing the results avoids repeated summations during term sorting invoked by SparsePolynomial::from_coefficients_vec, which can be significant for large term lists. In is_constant, an early return when the term is empty eliminates unnecessary degree aggregation for the common constant case, while retaining a fallback degree() == 0 check to remain correct for terms constructed without normalization, such as SparseTerm(vec![(i, 0)]), which are present in tests.