perf(ff): parse bytes in 2^64 chunks; drop alloc in BE path#1069
Open
radik878 wants to merge 2 commits intoarkworks-rs:masterfrom
Open
perf(ff): parse bytes in 2^64 chunks; drop alloc in BE path#1069radik878 wants to merge 2 commits intoarkworks-rs:masterfrom
radik878 wants to merge 2 commits intoarkworks-rs:masterfrom
Conversation
Member
|
Thank you for the PR! Could you add tests that show the behaviour is preserved? E.g. specifically in test-templates? |
Contributor
Author
Did it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace per-byte accumulation in from_le_bytes_mod_order with 8-byte chunking using a precomputed 2^64 window. This reduces field multiplications by ~8x on long inputs while preserving semantics and constant-time field operations. Also rework from_be_bytes_mod_order to avoid reversing into a new Vec by streaming big-endian input in 2^64 chunks.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer