Work around for wasm_bindgen::JsError lacking no_std support#1079
Open
burdges wants to merge 1 commit intoarkworks-rs:masterfrom
Open
Work around for wasm_bindgen::JsError lacking no_std support#1079burdges wants to merge 1 commit intoarkworks-rs:masterfrom
burdges wants to merge 1 commit intoarkworks-rs:masterfrom
Conversation
I think wasm_bindgen should fix this error, but this provides a work around for now, which can be patched in. wasm-bindgen/wasm-bindgen#5025
Contributor
Author
|
Alright wasm-bindgen/wasm-bindgen#5029 seems like the right fix here, and wasm-bindgen updates often, so unless its devs care lots about older rustc version then I guess this PR should end up being closed. |
Contributor
|
Let me know if I can help thanks @burdges |
Contributor
Author
|
I think this serves primarily as a cargo patch target, but even there my PR to wasm-bindgen makes a better cargo patch target. We could close this now or just leave it open until wasm-bindgen advanced their MSRV enough to merge my patch or similar, not because merging it makes sense but because this might increase visibility for people who want to return JsErrors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think wasm_bindgen should fix this error, and if they did then this PR would break, so I'm not sure this PR should be merged, but this PR provides a work around for now, which can be patched in, so maybe worth having in a branch here.
wasm-bindgen/wasm-bindgen#5025
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer