Fix incorrect native field type detection in Poseidon sponge#167
Open
sashaodessa wants to merge 1 commit intoarkworks-rs:mainfrom
Open
Fix incorrect native field type detection in Poseidon sponge#167sashaodessa wants to merge 1 commit intoarkworks-rs:mainfrom
sashaodessa wants to merge 1 commit intoarkworks-rs:mainfrom
Conversation
sashaodessa
requested review from
Pratyush,
mmagician and
z-tech
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logical error in the
squeeze_field_elements_with_sizesmethod ofPoseidonSpongewhere the native field type case was incorrectly determined by comparing field characteristics instead of exact type matching.Problem: The method used
F::characteristic() == F2::characteristic()to determine if casting between fields was safe, which could lead to incorrect casts when different field types share the same characteristic.Solution: Changed the logic to use
TypeId::of::<F>() == TypeId::of::<F2>()for exact type matching, aligning with the existingsqueeze_field_elementsmethod.