Skip to content

Enhance MiMC test with negative validation checks #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

Description

This PR enhances the MiMC test by adding negative validation checks to ensure the proof system correctly rejects invalid inputs. These improvements include:

  1. Adding validation of random incorrect images in each test iteration
  2. Adding a specific test for tampered public inputs
  3. Improving error messages for failed assertions

This change strengthens the test suite by validating not only that valid proofs are accepted, but also that invalid proofs are properly rejected, which is a critical security aspect of zero-knowledge proof systems.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md (this is a test improvement only, no functional change)
  • Re-reviewed Files changed in the Github PR explorer

@VolodymyrBg VolodymyrBg requested a review from a team as a code owner March 20, 2025 14:50
@VolodymyrBg VolodymyrBg requested review from z-tech, Pratyush and weikengchen and removed request for a team March 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant