Skip to content

Conversation

@alireza-shirzad
Copy link
Contributor

@alireza-shirzad alireza-shirzad commented Jan 16, 2025

Description

Updates r1cs-std to account for the changes in arkworks-rs/snark#378. This is mostly a renaming pass, but is a breaking-change.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Copy link
Member

Please add a bash script which automates the migration.

@Pratyush Pratyush marked this pull request as ready for review March 3, 2025 19:29
@Pratyush Pratyush requested a review from a team as a code owner March 3, 2025 19:29
@Pratyush Pratyush requested review from mmagician, weikengchen and z-tech and removed request for a team March 3, 2025 19:29
@z-tech
Copy link

z-tech commented Mar 4, 2025

Could we fill in the description?

Is this purely a name change? And do we need or want this to be a breaking change?

@Pratyush
Copy link
Member

@z-tech does the new description look good?

@alireza-shirzad alireza-shirzad merged commit e273877 into arkworks-rs:master Mar 17, 2025
5 of 11 checks passed
@z-tech
Copy link

z-tech commented Mar 18, 2025

Yes, it's clear. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants