Disable Rand Dependency When Feature Unused#57
Open
ash-burnt wants to merge 3 commits intoarkworks-rs:masterfrom
Open
Disable Rand Dependency When Feature Unused#57ash-burnt wants to merge 3 commits intoarkworks-rs:masterfrom
ash-burnt wants to merge 3 commits intoarkworks-rs:masterfrom
Conversation
Member
|
Hi, can you switch it so that maybe we keep I think you can do this by changing |
Author
|
This keeps rand, just sets it as an optional dependency if none of the features need it. If you don't have a feature using it, it won't get pulled in and won't cause issues Most dependencies should be optional, this is an irk across most of the arkworks tools. For something like verification only, we still end up pulling in most of the unused dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The rand and getrandom libraries are a particular nuisance when trying to compile Rust to certain architectures, like wasm.
This PR sets the rand dependency to optional, meaning it will not enter the dependency tree when features don't call for it, and should allow wasm compilation to complete
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer