[ATfE] Fix and re-enable package test on MacOS #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package test implementation curretly relies on using the CMake `tar` command to unpack the toolchain for testing. As this CMake command is not able to handle .dmg image files, the package test was disabled temporarily on MacOS platforms. This change implements an alternative way to unpack the toolchain .dmg file for testing on MacOS. It introduces a new `extract_dmg.sh` script that makes use of the `hdiutil` program to extract the contents correctly. With the fix in place, this change also re-enables the package tests on MacOS platforms.
statham-arm
reviewed
May 21, 2025
statham-arm
reviewed
May 21, 2025
statham-arm
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package test implementation curretly relies on using the CMake
tarcommand to unpack the toolchain for testing. As this CMake command is
not able to handle .dmg image files, the package test was disabled
temporarily on MacOS platforms.
This change implements an alternative way to unpack the toolchain .dmg
file for testing on MacOS. It introduces a new
extract_dmg.shscriptthat makes use of the
hdiutilprogram to extract the contentscorrectly. With the fix in place, this change also re-enables the
package tests on MacOS platforms.