Skip to content

Comments

[ATfE] Add CMake Build Options for Multiple C Libraries#687

Draft
HugoSilvaSantos wants to merge 28 commits intoarm:arm-softwarefrom
HugoSilvaSantos:arm-software-libc-atfe-package
Draft

[ATfE] Add CMake Build Options for Multiple C Libraries#687
HugoSilvaSantos wants to merge 28 commits intoarm:arm-softwarefrom
HugoSilvaSantos:arm-software-libc-atfe-package

Conversation

@HugoSilvaSantos
Copy link
Contributor

  • Draft PR

Hugo Silva and others added 4 commits January 27, 2026 16:09
- Add enable flags per libc
- Fix COPYING.NEWLIB error when creating the atfe package
- Fix samples related issue
@github-actions github-actions bot added the downstream-change Downstream change to LLVM tree label Jan 27, 2026
@github-actions
Copy link

This pull review modifies files outside of the arm-software directory, so please ensure it follows the Downstream Patch Policy.
An automated check will test if the tagging requirements have been met. Please wait for approving reviews from both Arm Toolchain for Embedded and Arm Toolchain for Linux teams before merging.

@HugoSilvaSantos HugoSilvaSantos force-pushed the arm-software-libc-atfe-package branch from 793356a to 37e947a Compare January 27, 2026 16:38
@dcandler dcandler removed the downstream-change Downstream change to LLVM tree label Jan 27, 2026
Comment on lines 935 to 936
set(LLVM_TOOLCHAIN_MINGW_LICENSE_LINES
" - MinGW runtime DLLs: ${_mingw_license_dir}/COPYING.MinGW-w64-runtime.txt, ${_mingw_license_dir}/COPYING3.GCC, ${_mingw_license_dir}/COPYING.RUNTIME\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MinGW line can be appended to LLVM_TOOLCHAIN_LICENSE_SUMMARY_LINES, there is no need for a separate variable now.

endforeach()
if(LLVM_TOOLCHAIN_LICENSE_SUMMARY_LINES)
set(LLVM_TOOLCHAIN_LICENSE_FOOTER_LINES
"Libc licenses refer to their source files. Sources are identified in VERSION.txt.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is only going to be true for picolibc and/or newlib since they use external repos. It may be necessary to set this per libc, e.g. like _libc_license_names is.

"LLVM_TOOLCHAIN_ENABLE_NEWLIB or LLVM_TOOLCHAIN_ENABLE_LLVMLIBC to ON.")
endif()

list(GET LLVM_TOOLCHAIN_ENABLED_LIBCS 0 LLVM_TOOLCHAIN_PRIMARY_LIBC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants