[ATfE] Add CMake Build Options for Multiple C Libraries#687
[ATfE] Add CMake Build Options for Multiple C Libraries#687HugoSilvaSantos wants to merge 28 commits intoarm:arm-softwarefrom
Conversation
HugoSilvaSantos
commented
Jan 20, 2026
- Draft PR
- Add enable flags per libc
- Fix COPYING.NEWLIB error when creating the atfe package - Fix samples related issue
|
This pull review modifies files outside of the |
793356a to
37e947a
Compare
arm-software/embedded/CMakeLists.txt
Outdated
| set(LLVM_TOOLCHAIN_MINGW_LICENSE_LINES | ||
| " - MinGW runtime DLLs: ${_mingw_license_dir}/COPYING.MinGW-w64-runtime.txt, ${_mingw_license_dir}/COPYING3.GCC, ${_mingw_license_dir}/COPYING.RUNTIME\n") |
There was a problem hiding this comment.
The MinGW line can be appended to LLVM_TOOLCHAIN_LICENSE_SUMMARY_LINES, there is no need for a separate variable now.
| endforeach() | ||
| if(LLVM_TOOLCHAIN_LICENSE_SUMMARY_LINES) | ||
| set(LLVM_TOOLCHAIN_LICENSE_FOOTER_LINES | ||
| "Libc licenses refer to their source files. Sources are identified in VERSION.txt.") |
There was a problem hiding this comment.
I feel this is only going to be true for picolibc and/or newlib since they use external repos. It may be necessary to set this per libc, e.g. like _libc_license_names is.
arm-software/embedded/CMakeLists.txt
Outdated
| "LLVM_TOOLCHAIN_ENABLE_NEWLIB or LLVM_TOOLCHAIN_ENABLE_LLVMLIBC to ON.") | ||
| endif() | ||
|
|
||
| list(GET LLVM_TOOLCHAIN_ENABLED_LIBCS 0 LLVM_TOOLCHAIN_PRIMARY_LIBC) |
There was a problem hiding this comment.
Note this is still relevant.