Skip to content

feat: Copy firmware when container starts not when it's created#18

Merged
yejseo01 merged 2 commits into
arm:mainfrom
yejseo01:reorder
Oct 20, 2025
Merged

feat: Copy firmware when container starts not when it's created#18
yejseo01 merged 2 commits into
arm:mainfrom
yejseo01:reorder

Conversation

@yejseo01

Copy link
Copy Markdown
Contributor

Changes

  • Rename the annotation variable names to be more descriptive
  • Add comments above some functions to briefly describe its feture
  • remove calling of remoteproc.StoreFirmware(firmwarePath) from create()
  • store the original firmware path into the state annotation in create()
  • Improve overused error messages
  • start() now reads from the container state annotation on the original firmware path, and copies it to /lib/firmware before starting the remoteproc. This encapsulates all remoteproc driver interaction within start()

Checklist

  • 🤖 This change is covered by tests as required.
  • 🤹 All required manual testing has been performed.
  • 📖 All documentation updates are complete.

@yejseo01
yejseo01 requested a review from a team as a code owner October 16, 2025 13:21

@muchzill4 muchzill4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need to fix all calls to RemoveFirmware as it will attempt to delete the source firmware file, not the copy
  • Perhaps feat: Copy firmware when container starts not when it's created

Comment thread internal/oci/annotations.go Outdated
Comment thread internal/remoteproc/remoteproc.go Outdated
Comment thread internal/runtime/delete.go Outdated
Comment thread internal/runtime/delete.go Outdated
Comment thread internal/runtime/kill.go Outdated
Comment thread internal/runtime/start.go Outdated
Comment thread internal/runtime/start.go Outdated
Comment thread internal/runtime/state.go Outdated
@yejseo01 yejseo01 changed the title feat: migrate firmware copying to start not create feat: Copy firmware when container starts not when it's created Oct 16, 2025
Comment thread internal/oci/annotations.go Outdated
Comment thread internal/runtime/create.go Outdated
Comment thread internal/runtime/delete.go Outdated
Comment thread internal/oci/annotations.go Outdated
@yejseo01
yejseo01 requested a review from muchzill4 October 20, 2025 09:22

@muchzill4 muchzill4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still trying to delete firmware even if we didn't store it previously. I tried to better explain what I mean in delete.go. Let me know if it needs further clarification. 👍

Comment thread internal/runtime/delete.go Outdated
Comment thread internal/runtime/start.go
@yejseo01
yejseo01 requested a review from muchzill4 October 20, 2025 10:20
@yejseo01
yejseo01 force-pushed the reorder branch 7 times, most recently from e05fa97 to f45704d Compare October 20, 2025 11:41
Signed-off-by: Yejin Seo <yejseo01@arm.com>
@yejseo01
yejseo01 merged commit 239ed49 into arm:main Oct 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants