Skip to content

refactor: Remove priority classes from executor CR#374

Merged
dejanzele merged 2 commits intoarmadaproject:mainfrom
Sovietaced:remove-priority-classes
Jan 5, 2026
Merged

refactor: Remove priority classes from executor CR#374
dejanzele merged 2 commits intoarmadaproject:mainfrom
Sovietaced:remove-priority-classes

Conversation

@Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Jan 5, 2026

Pull Request Template

Description

Now that the Armada preemption behavior has been clarified we know that preemption happens in the scheduler and not the k8s layer. As such we don't need k8s priority classes to be configured.

Fixes # (issue)

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions to reproduce these tests. List any relevant details for your test configuration.

  • Test Configuration:

    • Kubernetes Version:
    • Helm Version:
    • OS:
  • Test Steps:

    1. Step 1
    2. Step 2
    3. ...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced Sovietaced force-pushed the remove-priority-classes branch from f22fcab to dc40479 Compare January 5, 2026 17:06
@Sovietaced Sovietaced changed the title Remove priority classes from executor CR refactor: Remove priority classes from executor CR Jan 5, 2026
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced Sovietaced force-pushed the remove-priority-classes branch from dc40479 to 18aae69 Compare January 5, 2026 17:11
@Sovietaced Sovietaced marked this pull request as ready for review January 5, 2026 17:44
@dejanzele dejanzele self-requested a review January 5, 2026 17:52
@dejanzele dejanzele merged commit f3bbbb1 into armadaproject:main Jan 5, 2026
23 checks passed
@Sovietaced Sovietaced deleted the remove-priority-classes branch January 5, 2026 17:53
@Sovietaced Sovietaced restored the remove-priority-classes branch January 5, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants